-
Notifications
You must be signed in to change notification settings - Fork 31
Fix CUDA sparse_to_dense #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
==========================================
+ Coverage 93.42% 93.59% +0.16%
==========================================
Files 44 44
Lines 2829 2826 -3
==========================================
+ Hits 2643 2645 +2
+ Misses 186 181 -5 ☔ View full report in Codecov by Sentry. |
|
We should also remove the following line in In order to test whether our setting for |
|
I see some benchmark regression on the pseudo inverse spectrum. Very strange. |
|
These are the benchmarks I did locally Dev BranchMain BranchI think that it is not related to this PR. |
Checklist
Thank you for contributing to
QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.make test.juliaformatted by running:make format.docs/folder) related to code changes were updated and able to build locally by running:make docs.CHANGELOG.mdshould be updated (regarding to the code changes) and built by running:make changelog.Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.