Skip to content

Conversation

@albertomercurio
Copy link
Member

@albertomercurio albertomercurio commented Feb 4, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.59%. Comparing base (504ac18) to head (74a3c3e).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
ext/QuantumToolboxCUDAExt.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   93.42%   93.59%   +0.16%     
==========================================
  Files          44       44              
  Lines        2829     2826       -3     
==========================================
+ Hits         2643     2645       +2     
+ Misses        186      181       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytdHuang
Copy link
Member

ytdHuang commented Feb 6, 2025

We should also remove the following line in runtest.jl : https://github.com/qutip/QuantumToolbox.jl/blob/main/test/runtests.jl#L73

In order to test whether our setting for allowscalar(false) really works

@albertomercurio
Copy link
Member Author

I see some benchmark regression on the pseudo inverse spectrum. Very strange.

@albertomercurio
Copy link
Member Author

albertomercurio commented Feb 8, 2025

These are the benchmarks I did locally

Dev Branch

  "Correlations and Spectrum" => 2-element BenchmarkTools.BenchmarkGroup:
          tags: []
          "Spectrum" => 2-element BenchmarkTools.BenchmarkGroup:
                  tags: []
                  "Pseudo Inverse" => TrialEstimate(22.838 ms)
                  "Exponential Series" => TrialEstimate(22.863 ms)
          "FFT Correlation" => TrialEstimate(7.536 ms)

Main Branch

"Correlations and Spectrum" => 2-element BenchmarkTools.BenchmarkGroup:
          tags: []
          "Spectrum" => 2-element BenchmarkTools.BenchmarkGroup:
                  tags: []
                  "Pseudo Inverse" => TrialEstimate(21.464 ms)
                  "Exponential Series" => TrialEstimate(22.773 ms)
          "FFT Correlation" => TrialEstimate(7.542 ms)

I think that it is not related to this PR.

@ytdHuang ytdHuang merged commit 0408069 into qutip:main Feb 8, 2025
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants