Skip to content

Conversation

@ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented May 28, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

As title, this PR switch our current Core tests structure into the Test Item Framework

For all the other (code quality and extension) tests, we still use the traditional Test.jl for faster precompilation in GitHub CI pipeline.

@ytdHuang ytdHuang added the Skip ChangeLog Skip changelog update check in PR label May 28, 2025
@ytdHuang ytdHuang changed the title Switch the tests to Test Item Framework Switch the tests to "Test Item Framework" May 28, 2025
@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.46%. Comparing base (a1d1627) to head (b12a5c8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
- Coverage   94.08%   93.46%   -0.63%     
==========================================
  Files          49       49              
  Lines        3042     3074      +32     
==========================================
+ Hits         2862     2873      +11     
- Misses        180      201      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ytdHuang ytdHuang marked this pull request as draft May 28, 2025 12:48
@ytdHuang ytdHuang changed the title Switch the tests to "Test Item Framework" Switch Core tests to "Test Item Framework" May 28, 2025
@ytdHuang ytdHuang marked this pull request as ready for review May 28, 2025 12:53
@ytdHuang ytdHuang requested a review from albertomercurio May 28, 2025 13:13
@albertomercurio albertomercurio merged commit a965621 into main Jun 2, 2025
17 of 19 checks passed
@ytdHuang ytdHuang deleted the testitems branch June 2, 2025 13:41
matteosecli pushed a commit to matteosecli/QuantumToolbox.jl that referenced this pull request Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip ChangeLog Skip changelog update check in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants