Open
Conversation
nathancday
requested changes
Feb 21, 2023
Member
nathancday
left a comment
nathancday
left a comment
There was a problem hiding this comment.
Thanks for this patch, and sorry I didn't see this for 3 months.
| shared_link <- x$shared_link | ||
| if (is.list(x$shared_link)) | ||
| shared_link <- x$shared_link$url | ||
| if (!is.list(x$shared_link)) |
Member
There was a problem hiding this comment.
can this just be an ifelse() all on 1 line `shared_link = ifelse(is.list....))?
Member
|
Was it always causing an error? Or was it only sometimes? I want to reproduce it and maybe add a test for the error |
|
Just commenting to say that the error still arises. I have just started using the package so I cannot attest to how widespread the issue is, but I am ready to test things if need be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x$shared_link was coming through as a list and causing an error with subsequent cat() call. This fix selects the url item from that list (if x$shared_link is a list).