Skip to content

shared link bug fix #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcdonohue wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

shared link bug fix #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion R/boxr_s3_classes.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,10 @@ print.boxr_file_reference <- function(x, ...) {
)
cat(" uploaded by :", x$modified_by$login, "\n")
cat(" owned by :", x$owned_by$login, "\n")
shared_link <- x$shared_link
if (is.list(x$shared_link))
shared_link <- x$shared_link$url
if (!is.list(x$shared_link))
Copy link
Copy Markdown
Member

@nathancday nathancday Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this just be an ifelse() all on 1 line `shared_link = ifelse(is.list....))?

shared_link <- x$shared_link
if (is.null(shared_link))
shared_link <- "None"
cat(" shared link :", shared_link, "\n\n")
Expand Down