Add skip_unless_r() #2094
Merged
Add skip_unless_r() #2094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the |
|
Looks like you assumed that a very obvious function should exist 😄 |
|
haha, oops. I guess when present the usual thing is to do Lines 94 to 99 in b56afbe |
|
I also tried to use |
hadley
approved these changes
Jul 23, 2025
Co-authored-by: Hadley Wickham <[email protected]>
Co-authored-by: Hadley Wickham <[email protected]>
MichaelChirico
commented
Jul 23, 2025
|
Hm, I thought it was possible to download the new snapshots from the GHA logs, I guess not. It may take me a few days to get to a machine that I can use to upload the snapshot output FYI. |
|
I can run those for you. |
hadley
reviewed
Jul 23, 2025
hadley
reviewed
Jul 23, 2025
|
Thank you! |
schloerke
added a commit
to schloerke/testthat
that referenced
this pull request
Jul 25, 2025
* upstream/HEAD: (250 commits) Implement `expect_shape()` (r-lib#1469) Re-enable catch tests on windows (r-lib#2104) Move digest to suggests (r-lib#2105) Support emscripten in `skip_on_os()` (r-lib#2103) Add `skip_unless_r()` (r-lib#2094) Require R 4.1 (r-lib#2101) Allow unquoting first arg for `expect_s4_class()` (r-lib#2065) typo fix (r-lib#2051) Explicitly pass `parent.frame()` in `it()` (r-lib#2086) Update vignette advice for migrating to {testthat} 3e (r-lib#2080) New praise messages (r-lib#1974) move '!' outside aggregation (r-lib#2067) Handle deprecation of std::uncaught_exception() (r-lib#2097) perf: use `anyNA()` (r-lib#2058) Upkeep (r-lib#2099) Implement `mock_output_sequence()` (r-lib#2061) Increment version number to 3.2.3.9000 Increment version number to 3.2.3 Update CRAN comments Finish off r-lib#2046 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2022. Feedback welcome.
I decided against an implicit default for the operator like
skip_unless_r("4.0.0")being>=or==implicitly. I've also kept a rigid one-space requirement for now, though that's easy to change tostrsplit(spec, "\\s*").