Skip to content

Conversation

@hadley
Copy link
Member

@hadley hadley commented Jul 31, 2025

  • Approved way of wrapping `expect_error()
  • Modern style argument checking
  • Use testthat_warn to avoid generating a backtrace

@EmilHvitfeldt can you please take a look since you're also working on this code?

* Approved way of wrapping `expect_error()
* Modern style argument checking
@hadley hadley requested a review from EmilHvitfeldt July 31, 2025 13:27
Copy link
Member

@EmilHvitfeldt EmilHvitfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks clean!

hadley and others added 2 commits August 1, 2025 07:57
@hadley hadley merged commit dc341fc into main Aug 1, 2025
10 of 11 checks passed
@hadley hadley deleted the setequal-upkeep branch August 1, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants