Remove default value

[Gsantomaggio]

while creating a queue. If not set the server has to use the default queue type for vhost

This PR aims to stop implicitly defaulting queue type to classic when creating/declaring a queue, allowing the broker to apply the vhost’s default queue type when the client does not explicitly set one.

Changes:

• Removed QueueType getter from IQueueSpecification and AmqpQueueSpecification (and corresponding API tracking entries).
• Updated DeclareAsync() logic intended to apply mandatory settings for quorum/stream queues.

Fixes: #146

[Copilot]

Pull request overview

This PR aims to stop implicitly defaulting queue type to classic when creating/declaring a queue, allowing the broker to apply the vhost’s default queue type when the client does not explicitly set one.

Changes:

• Removed QueueType getter from IQueueSpecification and AmqpQueueSpecification (and corresponding API tracking entries).
• Updated DeclareAsync() logic intended to apply mandatory settings for quorum/stream queues.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
RabbitMQ.AMQP.Client/PublicAPI.Unshipped.txt	Removes unshipped API entries for QueueType getter to match the new surface area.
RabbitMQ.AMQP.Client/Impl/AmqpQueueSpecification.cs	Removes the QueueType property and changes quorum/stream detection in DeclareAsync().
RabbitMQ.AMQP.Client/IEntities.cs	Removes QueueType getter from IQueueSpecification.

Comments suppressed due to low confidence (1)

RabbitMQ.AMQP.Client/Impl/AmqpQueueSpecification.cs:300

• In DeclareAsync this indexes _queueArguments["x-queue-type"] unconditionally and pattern-matches it against QueueType enum values, but Type(...) stores a string (e.g. "quorum"), and when the user does not call Type(...) the key won't exist. This will either throw KeyNotFoundException for the default case, or never match for quorum/stream (so the mandatory Exclusive(false).AutoDelete(false) override won't run). Use TryGetValue and compare against the stored string values ("quorum"/"stream"), or track the queue type in a separate nullable field and use that for the check while still sending the string argument to the server.

        public async Task<IQueueInfo> DeclareAsync()
        {
            if (_queueArguments["x-queue-type"] is QueueType.QUORUM or QueueType.STREAM)
            {
                // mandatory arguments for quorum queues and streams
                Exclusive(false).AutoDelete(false);
            }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.