Check server version on connection open #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zerpet
force-pushed
the
check-server-version
branch
from
83a1f21 to
9e82118
Compare
Zerpet
force-pushed
the
check-server-version
branch
from
9e82118 to
3143443
Compare
This will be useful when we implement SQL filter support.
Gsantomaggio
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces server version validation to the connection process, ensuring that the client only connects to supported RabbitMQ servers (version 4.0.0 or higher). It also adds internal utilities for version checks, updates dependencies, and improves type hints for remote properties.
Connection and Version Validation:
_validate_server_propertiesmethod inconnection.pyto ensure the server is RabbitMQ and its version is at least 4.0.0, raising aValidationCodeExceptionotherwise. Also added_is_server_version_gte_4_2_0for feature gating based on server version.REMOTE_ACTIVEstate before proceeding, making the connection process more robust. (_utils.py)Dependency and Type Improvements:
packaginglibrary as a dependency for reliable version parsing and comparison. (pyproject.toml, import inconnection.py) [1] [2]remote_propertiesproperty to explicitly indicate it may returnOptional[Data]. (_endpoints.py)Edit: trying out the copilot PR summary