fix: issues/64: Graph doesn't appear if all the "y" values are equal, but "x" values are different#65
fix: issues/64: Graph doesn't appear if all the "y" values are equal, but "x" values are different#65dynamichny wants to merge 3 commits intorainbow-me:masterfrom
Conversation
|
@osdnk Could you take a look? :) |
|
@dynamichny I just tested your code and the graph works fine as you attached. But this code has a bug. Since it edits the original data of greatestY and smallestY, if someone uses greatestY and smallestY value from useChartData, the value is incorrect. Should purposely greatestY - 1 and smallestY + 1 from the useChartData. |
|
@SophieJung7 Good point, so I guess I'd need to check if value is the same somewhere deeper, I'll check it later today |
|
Thnx a lot, @dynamichny ! Now it is working perfectly!:) |
|
guys, how much does it take usually to merge a request? |
|
@b0n1q it may take some time, there are already 4 PR's waiting for approval, if you need to have it fixed in your project, you can try to fix it locally and patch it using patch-package :) |

Problem:
Chart was appearing above the "canvas", because both extremes were exactly the same.
Solution:
Setting extremes to values between Y (so 1 and -1 for value 0) solves the problem.
Issue:
#64