Skip to content

fix: issues/64: Graph doesn't appear if all the "y" values are equal, but "x" values are different #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: issues/64: Graph doesn't appear if all the "y" values are equal, but "x" values are different #65

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d53f0f5
fix: extremes for the same value along the chart
dynamichny Jan 3, 2022
c578f65
fix: check if extremes are the same in other scope
dynamichny Jan 4, 2022
07949af
style: remove added new lines
dynamichny Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/charts/linear/ChartPath.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@ function combineConfigs(a, b) {

const parse = (data, yRange) => {
const { greatestY, smallestY } = findYExtremes(data);
const minY = yRange ? yRange[0] : smallestY.y;
const maxY = yRange ? yRange[1] : greatestY.y;
const sameExtremes = smallestY.y === greatestY.y ? 1 : 0;
const minY = yRange ? yRange[0] : smallestY.y - sameExtremes;
const maxY = yRange ? yRange[1] : greatestY.y + sameExtremes;
const smallestX = data[0];
const greatestX = data[data.length - 1];
return [
Expand Down