Skip to content

WIP: update external secrets from the shared ES account secret-manager#62

Open
Priyankasaggu11929 wants to merge 1 commit intorajaskakodkar:mainfrom
Priyankasaggu11929:update-external-secrets
Open

WIP: update external secrets from the shared ES account secret-manager#62
Priyankasaggu11929 wants to merge 1 commit intorajaskakodkar:mainfrom
Priyankasaggu11929:update-external-secrets

Conversation

@Priyankasaggu11929
Copy link
Collaborator

No description provided.

@prowtce
Copy link
Contributor

prowtce bot commented Apr 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Priyankasaggu11929
Copy link
Collaborator Author

@rajaskakodkar Need help understanding how to test this updated External Secrets file?

If I apply the manifest in the current Prow PoC cluster, it would check for the secrets in the ES account secret-manager? Or I need to follow some more steps to point the current cluster to the new secret-manager?

@Priyankasaggu11929 Priyankasaggu11929 force-pushed the update-external-secrets branch from 16bf11d to f8ade6b Compare April 7, 2022 06:18
@rajaskakodkar
Copy link
Owner

@Priyankasaggu11929 In this PR you have touched external-secrets.yaml and kubernetes-external-secrets-sa.yaml. One way to test this is apply all the untouched kubernetes-external-secrets*.yaml from https://github.com/rajaskakodkar/tanzu-test-infra/tree/main/config/prow + the files you have touched in this PR. All the secrets mentioned in external-secrets.yaml should be created in the cluster where you apply these files.

@Priyankasaggu11929 Priyankasaggu11929 changed the title update external secrets from the shared ES account secret-manager WIP: update external secrets from the shared ES account secret-manager Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants