Skip to content

Some minor changes from error handling refactor #74#562

Merged
joelvdavies merged 3 commits intodevelopfrom
some-minor-fixes-from-error-handling-#74
Jul 22, 2025
Merged

Some minor changes from error handling refactor #74#562
joelvdavies merged 3 commits intodevelopfrom
some-minor-fixes-from-error-handling-#74

Conversation

@joelvdavies
Copy link
Contributor

@joelvdavies joelvdavies commented Jul 11, 2025

Description

Applies some minor changes found while working on #517.

  • The TestDelete in e2e/test_item.py showed different error messages getting an item and deleting one that doesn't exist when they could be the same
  • test_update_name_to_duplicate in TestUpdate inside test_manufacturer.py (repositories) - did not actually call or assert anything

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Relates to #74

@joelvdavies joelvdavies self-assigned this Jul 11, 2025
@joelvdavies joelvdavies added the enhancement New feature or request label Jul 11, 2025
@joelvdavies joelvdavies changed the title Fix inconsistent error message for getting a non-existent item #74 Some minor changes from error handling refactor #74 Jul 11, 2025
@joelvdavies joelvdavies force-pushed the some-minor-fixes-from-error-handling-#74 branch 2 times, most recently from 534455f to 4941dc5 Compare July 11, 2025 13:29
@joelvdavies joelvdavies force-pushed the some-minor-fixes-from-error-handling-#74 branch 2 times, most recently from 0cbb06b to 484261b Compare July 11, 2025 13:53
@joelvdavies joelvdavies requested a review from VKTB July 15, 2025 08:20
@joelvdavies joelvdavies marked this pull request as ready for review July 15, 2025 08:20
VKTB
VKTB previously approved these changes Jul 17, 2025
@joelvdavies joelvdavies force-pushed the some-minor-fixes-from-error-handling-#74 branch from 484261b to 2c87835 Compare July 22, 2025 08:28
@joelvdavies joelvdavies changed the base branch from add-system-types-to-systems-#537 to develop July 22, 2025 08:28
@joelvdavies joelvdavies dismissed VKTB’s stale review July 22, 2025 08:28

The base branch was changed.

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.36%. Comparing base (94f0015) to head (2c87835).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #562      +/-   ##
===========================================
+ Coverage    89.11%   89.36%   +0.25%     
===========================================
  Files           51       51              
  Lines         1865     1900      +35     
===========================================
+ Hits          1662     1698      +36     
+ Misses         203      202       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joelvdavies joelvdavies requested a review from VKTB July 22, 2025 08:33
@joelvdavies joelvdavies merged commit 4914e19 into develop Jul 22, 2025
6 checks passed
@joelvdavies joelvdavies deleted the some-minor-fixes-from-error-handling-#74 branch July 22, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants