Rails 7.1 upgrade #19953
Merged
Rails 7.1 upgrade #19953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwelch-r7
force-pushed
the
rails-7.1-upgrade
branch
13 times, most recently
from
9e1d9ec to
6121b29
Compare
dwelch-r7
force-pushed
the
rails-7.1-upgrade
branch
2 times, most recently
from
07da633 to
402ddd7
Compare
dwelch-r7
force-pushed
the
rails-7.1-upgrade
branch
3 times, most recently
from
60ec817 to
0ddcc13
Compare
dwelch-r7
changed the title
dwelch-r7
force-pushed
the
rails-7.1-upgrade
branch
4 times, most recently
from
2776c32 to
3f0a933
Compare
dwelch-r7
force-pushed
the
rails-7.1-upgrade
branch
from
3f0a933 to
4b19586
Compare
dwelch-r7
force-pushed
the
rails-7.1-upgrade
branch
from
4b19586 to
47b5f86
Compare
adfoster-r7
reviewed
Apr 11, 2025
| } | ||
| ApplicationRecord.connection_pool.with_connection do | ||
| # There's a bug in Rails 7.1 where ApplicationRecord.connection.active? returns false even though we can get a connection | ||
| # calling `verify!` instead will ensure we are connected even if `active?` incorrectly returns false |
Contributor
There was a problem hiding this comment.
It'd be great to leave repro steps or a link to the problematic code so future travellers can know more about this comment 👍
adfoster-r7
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7.1 upgrade