Skip to content

Stop relying on constexpr for host+device access in span types #21190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vuule wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop relying on constexpr for host+device access in span types #21190

vuule wants to merge 1 commit into from
+11 −8

Conversation

@vuule
Copy link
Contributor

@vuule vuule commented Jan 26, 2026 •
edited
Loading

Description

Issue #17797

The members of cudf's span types that do not access the pointed-to data should be callable from host and device, and at compile time. Currently most of these members rely on implicit host+device access from being constexpr. This PR adds CUDF_HOST_DEVICE to the members so everything keeps the access even if/when we unset--expt-relaxed-constexpr.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 26, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jan 26, 2026
@vuule vuule added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 26, 2026
@vuule
Copy link
Contributor Author

vuule commented Jan 26, 2026

/ok to test 39fe45b

@vuule vuule marked this pull request as ready for review January 27, 2026 20:00
@vuule vuule requested a review from a team as a code owner January 27, 2026 20:00
@vuule vuule requested review from bdice and karthikeyann January 27, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@karthikeyann karthikeyann Awaiting requested review from karthikeyann karthikeyann is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

At least 1 approving review is required to merge this pull request.

Assignees

@vuule vuule

Labels

improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vuule