Skip to content

ads7846 touch overlay fixups#6760

Merged
pelwell merged 2 commits intoraspberrypi:rpi-6.12.yfrom
6by9:rpi-6.12.y-dtoverlays
Apr 2, 2025
Merged

ads7846 touch overlay fixups#6760
pelwell merged 2 commits intoraspberrypi:rpi-6.12.yfrom
6by9:rpi-6.12.y-dtoverlays

Conversation

@6by9
Copy link
Contributor

@6by9 6by9 commented Apr 2, 2025

From comments on #5694 add in all the overrides to ads7846, and tidy them up on piscreen.

6by9 added 2 commits April 2, 2025 12:40
It had swapxy, but no way to trigger the X and Y inversions

Also use the generic "touchscreen-swapped-x-y" for swapxy
instead of the TI specific "ti,swap-xy".

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
The overlay had the TI proprietary "ti,swap-xy" defined by default,
but the override for swapxy then used the generic "touchscreen-swapped-x-y"

Swap the default to use "touchscreen-swapped-x-y" to make the configuration
consistent.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
@pelwell
Copy link
Contributor

pelwell commented Apr 2, 2025

Given that the two commits are in the same PR and will be merged simultaneously by the same person, I don't see the point in setting up a problem in the first commit and solving it in the second. I happened to read the second commit message first and was left thinking that you were fixing an existing problem.

Otherwise, approved.

@6by9
Copy link
Contributor Author

6by9 commented Apr 2, 2025

Given that the two commits are in the same PR and will be merged simultaneously by the same person, I don't see the point in setting up a problem in the first commit and solving it in the second. I happened to read the second commit message first and was left thinking that you were fixing an existing problem.

I don't think I have.
One patch is on ads7846-overlay, and the other is on piscreen-overlay. They both use the same touch controller, but each had their own deficiencies.

@pelwell
Copy link
Contributor

pelwell commented Apr 2, 2025

Sorry, you're right - I read it as being all about the ads7846 touch overlay.

@pelwell pelwell merged commit 2d3903d into raspberrypi:rpi-6.12.y Apr 2, 2025
13 checks passed
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Apr 2, 2025
…se HATs

See: raspberrypi/linux#6758

kernel: ads7846 touch overlay fixups
See: raspberrypi/linux#6760

kernel: staging: bcm2835-camera: Initialise dev in v4l2_dev
See: raspberrypi/linux#6754

kernel: media: i2c: imx415: Correct hmax_min values for 891Mbps/lane
See: raspberrypi/linux#6750

kernel: PCI: pcie-brcmstb: fake MSIx support on internal MSI target
See: raspberrypi/linux#6761

kernel: DRM fixes for cropping P030/SAND128 on Pi5
See: raspberrypi/linux#6741

kernel: Show process name in set_mempolicy() ignored message
See: raspberrypi/linux#6762
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request Apr 2, 2025
…se HATs

See: raspberrypi/linux#6758

kernel: ads7846 touch overlay fixups
See: raspberrypi/linux#6760

kernel: staging: bcm2835-camera: Initialise dev in v4l2_dev
See: raspberrypi/linux#6754

kernel: media: i2c: imx415: Correct hmax_min values for 891Mbps/lane
See: raspberrypi/linux#6750

kernel: PCI: pcie-brcmstb: fake MSIx support on internal MSI target
See: raspberrypi/linux#6761

kernel: DRM fixes for cropping P030/SAND128 on Pi5
See: raspberrypi/linux#6741

kernel: Show process name in set_mempolicy() ignored message
See: raspberrypi/linux#6762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants