Fix minor unused/uninitialized warnings from G++ #1786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good |
earlephilhower
added a commit
to earlephilhower/arduino-pico
that referenced
this pull request
Aug 17, 2024
Remove the skipped error messages once the following PR merged: raspberrypi/pico-sdk#1786
earlephilhower
added a commit
to earlephilhower/arduino-pico
that referenced
this pull request
Aug 17, 2024
* Update to 2.0.0 SDK * Board type needs to be set before earliest SDK setup * Platform includes update * Boot2 files * Simple compilation issues * Build and link * PIO rebuild with version * Newlib wrapper update * Force inclusion of runtime_init_* fcns The linker was dropping all references to the library's included runtime_init_xxx functions and hence things like the IRQ vector table and mutexes and alarms weren't properly set up leading to instant crashes on start up.. Explicitly call out one function from the object file stored in the .A to force the inclusion of all the functions. May be a better way, heppy to hear any ideas. * Fix SPI GPIO calls * Fix Ethernet GPIO * Remove SDK warnings Remove the skipped error messages once the following PR merged: raspberrypi/pico-sdk#1786 * BTStack moved SBC encode/decode paths * Platform.IO fixes * BT No longer has special absolute mouse * Rebuild and update OTA * Rebuild BearSSL, too * Update liker file to latest SDK * Clean up libpicocmake * Clean up LWIP/BT library names
kilograham
reviewed
Aug 20, 2024
kilograham
reviewed
Aug 20, 2024
kilograham
changed the title
|
An ok - I had wondered if this was a c++ thing - the {0} is valid C but had seen reports of some versions (albeit old) reporting that exact message |
|
I had forgot about that simpler |
|
As this is now a one-character change, it might be worth squashing the commits? |
Use empty initializer list for struct clearing, avoiding a pedantic warning from G++ 12 and 14. Fixes raspberrypi#1785
|
Done, thx! |
earlephilhower
changed the title
kilograham
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decorate an unused parameter in the timer API and fill in all structure elements in a PIO API call that generate warnings under GCC 12.
Fixes #1785