Remove deprecated uses of FetchContent_Populate #2169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cannot use MakeAvailable as the files shouldn't be added to the build, so instead uses the full signature for FetchContent_Populate Fixes raspberrypi#2124
lurch
reviewed
Jan 7, 2025
lurch
reviewed
Jan 8, 2025
kilograham
approved these changes
Jan 20, 2025
will-v-pi
added a commit
to will-v-pi/pico-sdk
that referenced
this pull request
Mar 20, 2025
* Remove deprecated uses of FetchContent_Populate Cannot use MakeAvailable as the files shouldn't be added to the build, so instead uses the full signature for FetchContent_Populate Fixes raspberrypi#2124 * Fix GIT_SUBMODULES_RECURSE for older CMake versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the deprecated uses of FetchContent_Populate (see #2124)
The SDK cannot just use MakeAvailable as the files shouldn't be added to the build, so instead this uses the full signature for FetchContent_Populate which has not been deprecated. The FetchContent_Declare call is kept in
pico_sdk_import.cmakeelse it will re-clone the SDK for every new build directory whenPICO_SDK_FETCH_FROM_GIT_PATHis set, rather than re-using the cloned SDK inPICO_SDK_FETCH_FROM_GIT_PATH.Fixes #2124