Skip to content

Adds Waveshare RP2350 One board #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Adds Waveshare RP2350 One board #2174

wants to merge 1 commit into from

Conversation

@patvdleer
Copy link

Refs #2173

@kilograham kilograham requested a review from lurch January 11, 2025 19:52
@kilograham kilograham added this to the 2.1.1 milestone Jan 11, 2025
lurch
lurch previously approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@lurch lurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lurch lurch linked an issue Jan 16, 2025 that may be closed by this pull request
Add support for Waveshare RP2350 One board #2173
Closed
@lurch lurch dismissed their stale review January 16, 2025 12:02

Duplicate

@lurch
Copy link
Contributor

lurch commented Jan 16, 2025

I've just realised that #2145 (which is from @waveshare themselves) also includes waveshare_rp2350_one.h, so this PR should probably be closed?

@lurch lurch mentioned this pull request Jan 16, 2025
Merged
@lurch
Copy link
Contributor

lurch commented Jan 17, 2025

Thanks for your contribution, but #2145 adds this board and many others.

@lurch lurch closed this Jan 17, 2025
@patvdleer patvdleer deleted the develop branch January 24, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lurch lurch lurch left review comments

Assignees

@lurch lurch

Labels

board settings

Projects

None yet

Milestone

2.1.1

Development

Successfully merging this pull request may close these issues.

Add support for Waveshare RP2350 One board

3 participants

@patvdleer @lurch @kilograham