-
Couldn't load subscription status.
- Fork 1.1k
Added some Waveshare board support #2145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@waveshare Apologies for the delay in getting round to reviewing this. However if I compare the but the version in #2174 says: and https://www.waveshare.com/wiki/RP2350-One#Pinout_Definition also says that there's a WS2812 connected to but your pinout diagram seems to show that GP16 isn't available on any of the user-accessible pins? |
|
Sorry, this is our mistake, #2174 is right, we will fix it soon |
4ad6a03 to
6224c6f
Compare
|
Hello, |
|
Thanks for the updates, my However I see that in various different files you've defined: (along with the associated pin-defines for each of those SPI interfaces). Similarly, perhaps it would make sense for both to be named just These suggestions are entirely optional; if you disagree I'm happy to approve this PR as-is. |
|
I think your suggestion is very good. Give me some time and I will solve it. |
|
Please take a look. |
Signed-off-by: eng33 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic 👍
Thank you for taking my comments into account, and thank you so much for adding all these board headers! ❤️
Signed-off-by: eng33 <[email protected]> Co-authored-by: eng33 <[email protected]>
Added some weveshare board support,PTAL.