-
Notifications
You must be signed in to change notification settings - Fork 6
VPLAY-11225 [Tech Debt] mediafailed event enhancements ( minor code etc ) #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev_sprint_25_2
Are you sure you want to change the base?
Conversation
4e13cdc to
42dab3c
Compare
48fccc1 to
2930196
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the MediaErrorEvent class to use separate majorCode and minorCode fields instead of a single code field, enabling more granular error categorization. The major codes group errors by category (e.g., 10 for init failures, 50 for DRM failures) while minor codes provide specific error identification within each category.
Key Changes:
- Split the single error
codeintomajorCodeandminorCodethroughout the codebase - Reorganized the
AAMPTuneFailureenum with category comments for better organization - Updated the
TuneFailureMapto include both major and minor codes with a systematic numbering scheme - Modified all API bindings and event listeners to expose both error code fields
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| AampEvent.h | Updated MediaErrorEvent class definition and AAMPTuneFailure enum to include major/minor code fields |
| AampEvent.cpp | Implemented getMajorCode() and getMinorCode() methods for MediaErrorEvent |
| AampEventListener.cpp | Updated legacy event structure population with major/minor codes |
| priv_aamp.cpp | Updated TuneFailureMap structure and error event sending logic to use major/minor codes |
| jsbindings/jseventlistener.cpp | Modified JS bindings to expose majorcode and minorcode properties |
| jsbindings/jsbindings.cpp | Updated JS event object construction with major/minor code properties |
| test/utests/fakes/FakeAampEvent.cpp | Updated fake implementation to match new constructor signature |
| test/utests/tests/AampEventTests/AampEventTests.cpp | Added comprehensive test coverage for major/minor codes including new L1 tests |
| AAMP-UVE-API.md | Updated error code documentation table to show major and minor codes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cd21d14 to
5faef28
Compare
2d1bbdb to
24387c7
Compare
24387c7 to
9361171
Compare
…tc ) Reason for change: Added minor code for MediaFailedEvent Risks: Low Test Procedure: Refer jira ticket Priority: P1 Signed-off-by: lashmintha <[email protected]>
9361171 to
b65cce7
Compare
Reason for change: Added minor code for MediaFailedEvent
Risks: Low
Test Procedure: Refer jira ticket
Priority: P1