Skip to content

Conversation

@lashmintha
Copy link
Contributor

Reason for change: Added minor code for MediaFailedEvent
Risks: Low
Test Procedure: Refer jira ticket
Priority: P1

@lashmintha lashmintha requested a review from a team as a code owner November 18, 2025 09:47
@lashmintha lashmintha force-pushed the feature/VPLAY-11225 branch 3 times, most recently from 4e13cdc to 42dab3c Compare November 19, 2025 09:11
@lashmintha lashmintha force-pushed the feature/VPLAY-11225 branch 2 times, most recently from 48fccc1 to 2930196 Compare November 25, 2025 17:00
@Vinish100 Vinish100 requested a review from Copilot November 26, 2025 05:14
Copilot finished reviewing on behalf of Vinish100 November 26, 2025 05:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the MediaErrorEvent class to use separate majorCode and minorCode fields instead of a single code field, enabling more granular error categorization. The major codes group errors by category (e.g., 10 for init failures, 50 for DRM failures) while minor codes provide specific error identification within each category.

Key Changes:

  • Split the single error code into majorCode and minorCode throughout the codebase
  • Reorganized the AAMPTuneFailure enum with category comments for better organization
  • Updated the TuneFailureMap to include both major and minor codes with a systematic numbering scheme
  • Modified all API bindings and event listeners to expose both error code fields

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
AampEvent.h Updated MediaErrorEvent class definition and AAMPTuneFailure enum to include major/minor code fields
AampEvent.cpp Implemented getMajorCode() and getMinorCode() methods for MediaErrorEvent
AampEventListener.cpp Updated legacy event structure population with major/minor codes
priv_aamp.cpp Updated TuneFailureMap structure and error event sending logic to use major/minor codes
jsbindings/jseventlistener.cpp Modified JS bindings to expose majorcode and minorcode properties
jsbindings/jsbindings.cpp Updated JS event object construction with major/minor code properties
test/utests/fakes/FakeAampEvent.cpp Updated fake implementation to match new constructor signature
test/utests/tests/AampEventTests/AampEventTests.cpp Added comprehensive test coverage for major/minor codes including new L1 tests
AAMP-UVE-API.md Updated error code documentation table to show major and minor codes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lashmintha lashmintha force-pushed the feature/VPLAY-11225 branch 2 times, most recently from cd21d14 to 5faef28 Compare November 27, 2025 06:57
…tc )

Reason for change: Added minor code for MediaFailedEvent
Risks: Low
Test Procedure: Refer jira ticket
Priority: P1

Signed-off-by: lashmintha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants