RDKEMW-15156: Provide a build frame work for trace-cmd#2801
RDKEMW-15156: Provide a build frame work for trace-cmd#2801
Conversation
There was a problem hiding this comment.
Pull request overview
This PR wires trace-cmd into the middleware build/output by making it (a) optionally included in the middleware packagegroup via a DISTRO_FEATURES flag and (b) packaged under the middleware-specific architecture feed.
Changes:
- Add conditional
trace-cmdinstallation topackagegroup-middleware-layerwhenenable_tracecmd_supportis present inDISTRO_FEATURES. - Override
PACKAGE_ARCHfor thetrace-cmdrecipe to use${MIDDLEWARE_ARCH}.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| recipes-core/packagegroups/packagegroup-middleware-layer.bb | Adds trace-cmd to the middleware packagegroup behind a DISTRO_FEATURES gate. |
| conf/include/mw-oss-override.inc | Forces trace-cmd packages to be emitted with middleware-specific PACKAGE_ARCH. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| meminsight \ | ||
| processmonitor \ |
There was a problem hiding this comment.
The PR title is scoped to adding trace-cmd support, but this hunk also adds two new unconditional runtime dependencies (meminsight, processmonitor). If these are required for trace-cmd they should be explained in the PR description/title; otherwise please move them to a separate PR or gate them behind an appropriate DISTRO_FEATURE to avoid unintended rootfs/packagegroup changes.
| meminsight \ | ||
| processmonitor \ |
There was a problem hiding this comment.
This recipe pins PV/PR manually, but PR is not bumped even though RDEPENDS is changing. Consider incrementing PR so package feeds/rootfs upgrades reliably pick up the new dependency set when PV stays the same.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| tzdata \ | ||
| util-linux \ | ||
| ${@bb.utils.contains('DISTRO_FEATURES', 'enable_gdb_support', "gdb ", "", d)} \ | ||
| ${@bb.utils.contains('DISTRO_FEATURES', 'enable_tracecmd_support', "trace-cmd ", "", d)} \ |
There was a problem hiding this comment.
This repo doesn’t appear to provide a 'trace-cmd' recipe/append (search only finds this new RDEPENDS entry and the PACKAGE_ARCH override). If the build environment doesn’t include a layer that ships trace-cmd (or a local recipe is expected), enabling 'enable_tracecmd_support' will cause an unresolved dependency; please confirm the provider layer is guaranteed or add the recipe in this PR.
| ${@bb.utils.contains('DISTRO_FEATURES', 'enable_tracecmd_support', "trace-cmd ", "", d)} \ |
| PACKAGE_ARCH:pn-os-release = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PACKAGE_ARCH:pn-gdb = "${MIDDLEWARE_ARCH}" | ||
| PACKAGE_ARCH:pn-trace-cmd = "${MIDDLEWARE_ARCH}" |
There was a problem hiding this comment.
The header comment in this file states these overrides are for OSS recipes built/released by the MW layer due to commercial licenses/other constraints. If trace-cmd is being added here for a different reason (it’s typically a standard OSS tool), consider updating the comment to reflect the actual criteria so future additions don’t become confusing.
No description provided.