Skip to content

RDKEMW-15156: Provide a build frame work for trace-cmd #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
satya200 wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

RDKEMW-15156: Provide a build frame work for trace-cmd #2801

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a721704
Update packagegroup-middleware-layer.bb
satya200 Mar 25, 2026
0ecf4a4
Enable trace-cmd
satya200 Mar 25, 2026
8bc6d5d
Update packagegroup-middleware-layer.bb
satya200 Mar 25, 2026
10e98e2
Update packagegroup-middleware-layer.bb
satya200 Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions conf/include/mw-oss-override.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ MULTILIB_VARIANTS:pn-os-release = " multilib "
PACKAGE_ARCH:pn-os-release = "${MIDDLEWARE_ARCH}"

PACKAGE_ARCH:pn-gdb = "${MIDDLEWARE_ARCH}"
PACKAGE_ARCH:pn-trace-cmd = "${MIDDLEWARE_ARCH}"
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header comment in this file states these overrides are for OSS recipes built/released by the MW layer due to commercial licenses/other constraints. If trace-cmd is being added here for a different reason (it’s typically a standard OSS tool), consider updating the comment to reflect the actual criteria so future additions don’t become confusing.

Copilot uses AI. Check for mistakes.
3 changes: 3 additions & 0 deletions recipes-core/packagegroups/packagegroup-middleware-layer.bb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ RDEPENDS:${PN} = " \
lsof \
${@bb.utils.contains('DISTRO_FEATURES', 'RDKTV_APP_HIBERNATE', "memcr ", "", d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'memcapture', 'memcapture', '', d)} \
meminsight \
processmonitor \
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title is scoped to adding trace-cmd support, but this hunk also adds two new unconditional runtime dependencies (meminsight, processmonitor). If these are required for trace-cmd they should be explained in the PR description/title; otherwise please move them to a separate PR or gate them behind an appropriate DISTRO_FEATURE to avoid unintended rootfs/packagegroup changes.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This recipe pins PV/PR manually, but PR is not bumped even though RDEPENDS is changing. Consider incrementing PR so package feeds/rootfs upgrades reliably pick up the new dependency set when PV stays the same.

Copilot uses AI. Check for mistakes.
remotedebugger \
networkmanager-plugin \
packagemanager \
Expand Down Expand Up @@ -187,6 +189,7 @@ RDEPENDS:${PN} = " \
tzdata \
util-linux \
${@bb.utils.contains('DISTRO_FEATURES', 'enable_gdb_support', "gdb ", "", d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'enable_tracecmd_support', "trace-cmd ", "", d)} \
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo doesn’t appear to provide a 'trace-cmd' recipe/append (search only finds this new RDEPENDS entry and the PACKAGE_ARCH override). If the build environment doesn’t include a layer that ships trace-cmd (or a local recipe is expected), enabling 'enable_tracecmd_support' will cause an unresolved dependency; please confirm the provider layer is guaranteed or add the recipe in this PR.

Suggested change
${@bb.utils.contains('DISTRO_FEATURES', 'enable_tracecmd_support', "trace-cmd ", "", d)} \

Copilot uses AI. Check for mistakes.
jquery \
ndisc6-rdnssd \
${@bb.utils.contains('DISTRO_FEATURES', 'enable_heaptrack', " heaptrack ", "", d)} \
Expand Down
Loading