Conversation
Reason for change: Remove lighttpd
There was a problem hiding this comment.
Pull request overview
Updates the middleware layer packagegroup to disable inclusion of lighttpd, aligning the image contents with the goal of removing lighttpd.
Changes:
- Adds conditional removal of
lighttpdfromDEPENDS. - Adds conditional removal of
lighttpdfromRDEPENDS:${PN}.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| DEPENDS:remove = "${@bb.utils.contains('DISTRO_FEATURES', 'enable_bolt_apps', "lighttpd ", "", d)}" | ||
| RDEPENDS:${PN}:remove = "${@bb.utils.contains('DISTRO_FEATURES', 'enable_bolt_apps', "lighttpd ", "", d)}" |
There was a problem hiding this comment.
The PR description/title indicates lighttpd should be removed, but this change only removes it when DISTRO_FEATURES contains enable_bolt_apps. For distros without that feature, lighttpd will still remain in both DEPENDS and RDEPENDS:${PN}. If the intent is to remove lighttpd unconditionally, drop it from the dependency lists (or invert/adjust the bb.utils.contains condition to match the intended behavior).
| lighttpd systemd sqlite3 \ | ||
| " | ||
| DEPENDS:remove = "${@bb.utils.contains('DISTRO_FEATURES', 'enable_bolt_apps', "lighttpd ", "", d)}" |
There was a problem hiding this comment.
Using DEPENDS += "... lighttpd ..." and then conditionally removing it via DEPENDS:remove makes the final dependency set harder to understand/maintain. Consider expressing the conditional directly where the dependency is added (e.g., use bb.utils.contains(...) in the DEPENDS/RDEPENDS lists) so the dependency is only introduced when needed.
| lighttpd systemd sqlite3 \ | |
| " | |
| DEPENDS:remove = "${@bb.utils.contains('DISTRO_FEATURES', 'enable_bolt_apps', "lighttpd ", "", d)}" | |
| ${@bb.utils.contains('DISTRO_FEATURES', 'enable_bolt_apps', '', ' lighttpd', d)} systemd sqlite3 \ | |
| " |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: Remove lighttpd