Skip to content

RDKMVE-2033:Disable lighttpd #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nairisnotavailable wants to merge 2 commits into
base: develop
Choose a base branch
from
+3 −2
Open

RDKMVE-2033:Disable lighttpd #2803

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
959df00
RDKMVE-2033:Disable lighttpd
Nairisnotavailable Mar 26, 2026
2bad2e4
Update packagegroup-middleware-layer.bb
Nairisnotavailable Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions recipes-core/packagegroups/packagegroup-middleware-layer.bb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,3 +221,5 @@ DEPENDS += " cjson crun jsonrpc libarchive libdash libevent gssdp harfbuzz hired
graphite2 curl openssl zlib glib-networking glib-2.0 \
lighttpd systemd sqlite3 \
"
DEPENDS:remove = "${@bb.utils.contains('DISTRO_FEATURES', 'enable_bolt_apps', "lighttpd ", "", d)}"
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using DEPENDS += "... lighttpd ..." and then conditionally removing it via DEPENDS:remove makes the final dependency set harder to understand/maintain. Consider expressing the conditional directly where the dependency is added (e.g., use bb.utils.contains(...) in the DEPENDS/RDEPENDS lists) so the dependency is only introduced when needed.

Suggested change
lighttpd systemd sqlite3 \
"
DEPENDS:remove = "${@bb.utils.contains('DISTRO_FEATURES', 'enable_bolt_apps', "lighttpd ", "", d)}"
${@bb.utils.contains('DISTRO_FEATURES', 'enable_bolt_apps', '', ' lighttpd', d)} systemd sqlite3 \
"

Copilot uses AI. Check for mistakes.
RDEPENDS:${PN}:remove = "${@bb.utils.contains('DISTRO_FEATURES', 'enable_bolt_apps', "lighttpd ", "", d)}"
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description/title indicates lighttpd should be removed, but this change only removes it when DISTRO_FEATURES contains enable_bolt_apps. For distros without that feature, lighttpd will still remain in both DEPENDS and RDEPENDS:${PN}. If the intent is to remove lighttpd unconditionally, drop it from the dependency lists (or invert/adjust the bb.utils.contains condition to match the intended behavior).

Copilot uses AI. Check for mistakes.
Loading