Skip to content

Conversation

Sonajeya31
Copy link
Contributor

Reason for change: Adding the motiondetector-hal-noop recipe
Test Procedure: Build and verify

@Sonajeya31 Sonajeya31 requested review from a team as code owners August 19, 2025 06:36
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rdkcmf-jenkins
Copy link

b'## Copyright scan failure
Commit: 2a7772c
Report detail: https://gist.github.com/rdkcmf-jenkins/5b86312b1209a66660fde239d1f8c286'

@rdkcmf-jenkins
Copy link

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/meta-rdk-halif-headers/83/rdkcentral/meta-rdk-halif-headers

  • Commit: 2a7772c

Report detail: gist'

@@ -0,0 +1,56 @@
# ============================================================================

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please remove the header on this file. By convention, metadata files don't have headers.
  2. This is an opensourced repo so is SRC_URI headed for opensourcing soon?
  3. If so, LICENSE will need to be Apache-2.0 before opensourcing.

@Sonajeya31 Sonajeya31 linked an issue Aug 20, 2025 that may be closed by this pull request
Copy link

@akhil1257 akhil1257 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta-rdk-halif-headers is for RDK hal headers recipe, this may not be the right place to add stub code recipe

@outdooruseonly
Copy link

I agree with Akhil. This repo is not for stub implementations. It is ONLY for hal interface definition.
If this change is thought to be required then the approach needs to be reviewed.
Please block pending review,

Copy link

@Ulrond Ulrond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed, it's in the wrong place.

# Copyright (c) 2016 RDK Management, LLC. All rights reserved.
# ============================================================================

SUMMARY = "Motion Detector HAL llama"
Copy link

@Ulrond Ulrond Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a platform independent meta directory, can't have anything specific to any platform, nor should it contain stubs.

These are used across all platforms in an independent layer way. They're a layer on their own in effect.

If you need stubs, then you need to create them in the vendor layer that implemented the code.

Are we looking at this the wrong way round though, what is the reason why you need a stub? Only on platforms where motion detector is present, then sure the code should exist all the way down... But on platforms where motion detection doesn't' exist, then none of the verticals should be installed, and errors should be reported back to the app, needs review with architecture team on how this should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants