-
Notifications
You must be signed in to change notification settings - Fork 1
RDKEMW-242: Sky-llama bringup in rdke #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
b'## Copyright scan failure |
@@ -0,0 +1,56 @@ | |||
# ============================================================================ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please remove the header on this file. By convention, metadata files don't have headers.
- This is an opensourced repo so is SRC_URI headed for opensourcing soon?
- If so, LICENSE will need to be Apache-2.0 before opensourcing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta-rdk-halif-headers is for RDK hal headers recipe, this may not be the right place to add stub code recipe
I agree with Akhil. This repo is not for stub implementations. It is ONLY for hal interface definition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be removed, it's in the wrong place.
# Copyright (c) 2016 RDK Management, LLC. All rights reserved. | ||
# ============================================================================ | ||
|
||
SUMMARY = "Motion Detector HAL llama" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a platform independent meta directory, can't have anything specific to any platform, nor should it contain stubs.
These are used across all platforms in an independent layer way. They're a layer on their own in effect.
If you need stubs, then you need to create them in the vendor layer that implemented the code.
Are we looking at this the wrong way round though, what is the reason why you need a stub? Only on platforms where motion detector is present, then sure the code should exist all the way down... But on platforms where motion detection doesn't' exist, then none of the verticals should be installed, and errors should be reported back to the app, needs review with architecture team on how this should work.
Reason for change: Adding the motiondetector-hal-noop recipe
Test Procedure: Build and verify