Skip to content

RDKEMW-242: Sky-llama bringup in rdke #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

RDKEMW-242: Sky-llama bringup in rdke #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions recipes-rdk-halif-headers/motiondetector-hal/motiondetector-hal-noop_git.bb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
# ============================================================================
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please remove the header on this file. By convention, metadata files don't have headers.
  2. This is an opensourced repo so is SRC_URI headed for opensourcing soon?
  3. If so, LICENSE will need to be Apache-2.0 before opensourcing.

# RDK MANAGEMENT, LLC CONFIDENTIAL AND PROPRIETARY
# ============================================================================
# This file (and its contents) are the intellectual property of RDK Management, LLC.
# It may not be used, copied, distributed or otherwise disclosed in whole or in
# part without the express written permission of RDK Management, LLC.
# ============================================================================
# Copyright (c) 2016 RDK Management, LLC. All rights reserved.
# ============================================================================

SUMMARY = "Motion Detector HAL llama"
Copy link

@Ulrond Ulrond Aug 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a platform independent meta directory, can't have anything specific to any platform, nor should it contain stubs.

These are used across all platforms in an independent layer way. They're a layer on their own in effect.

If you need stubs, then you need to create them in the vendor layer that implemented the code.

Are we looking at this the wrong way round though, what is the reason why you need a stub? Only on platforms where motion detector is present, then sure the code should exist all the way down... But on platforms where motion detection doesn't' exist, then none of the verticals should be installed, and errors should be reported back to the app, needs review with architecture team on how this should work.

SECTION = "console/utils"

LICENSE = "CLOSED"

PROVIDES += "virtual/vendor-motiondetector-hal"
RPROVIDES:${PN} = "virtual/vendor-motiondetector-hal"

SRC_URI = "${RDKE_GITHUB_ROOT}/motiondetector-hal-stubs;${RDKE_GITHUB_SRC_URI_SUFFIX}"
SRCREV = "0e63ee1a7c49223fbd009c9ea62596c3cd873773"

S = "${WORKDIR}/git"



ASNEEDED = ""

CFLAGS += "-fPIC -D_REENTRANT -Wall ${INCLUDE_DIRS} ${DBUS_LIB_DIR}"

# a HAL is machine specific
PACKAGE_ARCH = "${MIDDLEWARE_ARCH}"

# Shared libs created by the RDK build aren't versioned, so we need
# to force the .so files into the runtime package (and keep them
# out of -dev package).
FILES_SOLIBSDEV = ""
FILES:${PN} += "${libdir}/*.so"

TARGET_CC_ARCH += "${LDFLAGS}"

do_compile() {
oe_runmake -C ${S}/
}

do_install() {

# Install our HAL .h files required by the 'generic' devicesettings
install -d ${D}${includedir}/
install -m 0644 ${S}/*.h ${D}${includedir}/
install -d ${D}${libdir}
install -m 0755 ${S}/libmd-hal.so ${D}${libdir}/libmd-hal.so
ln -s libmd-hal.so ${D}${libdir}/libmd-hal.so.0
ln -s libmd-hal.so ${D}${libdir}/libmdhal.so
}
INSANE_SKIP:${PN} += "dev-so"
FILES:${PN} += "/usr/lib/libmd-hal.so /usr/lib/libmdhal.so"