RDKEMW-12842: Include meta-clang needed for secclient-rs #424
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for the meta-clang layer to the BitBake build configuration, which is needed for compiling the secclient-rs module. The change adds a conditional layer inclusion that checks for the presence of meta-clang before adding it to the build layers.
- Adds MANIFEST_PATH_META_CLANG variable check and conditional layer inclusion
- Uses the standard pattern of checking for layer.conf existence before adding the layer
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| " | ||
| BBLAYERS =+ "${@d.getVar('MANIFEST_PATH_META_CLANG') if d.getVar('MANIFEST_PATH_META_CLANG') is not None and os.path.isfile(d.getVar('MANIFEST_PATH_META_CLANG') + '/conf/layer.conf') else ''}" |
There was a problem hiding this comment.
The meta-clang layer addition lacks proper categorization with a comment header. All other layer groups in this file have descriptive comment headers (e.g., "# Common layers", "# Release layers: generic", "# Middleware layers: generic", "# Config layers: generic"). This addition should be placed in an appropriate logical group with a comment header, or if it belongs to the "Config layers: restricted/proprietary/optional" group above, it should be moved inside the multi-line BBLAYERS statement on lines 72-74.
| " | |
| BBLAYERS =+ "${@d.getVar('MANIFEST_PATH_META_CLANG') if d.getVar('MANIFEST_PATH_META_CLANG') is not None and os.path.isfile(d.getVar('MANIFEST_PATH_META_CLANG') + '/conf/layer.conf') else ''}" | |
| ${@d.getVar('MANIFEST_PATH_META_CLANG') if d.getVar('MANIFEST_PATH_META_CLANG') is not None and os.path.isfile(d.getVar('MANIFEST_PATH_META_CLANG') + '/conf/layer.conf') else ''} \ | |
| " |
| BBLAYERS =+ " \ | ||
| ${@d.getVar('MANIFEST_PATH_REGION_CONFIG') if d.getVar('MANIFEST_PATH_REGION_CONFIG') is not None and os.path.isfile(d.getVar('MANIFEST_PATH_REGION_CONFIG') + '/conf/layer.conf') else ''} \ | ||
| " | ||
| BBLAYERS =+ "${@d.getVar('MANIFEST_PATH_META_CLANG') if d.getVar('MANIFEST_PATH_META_CLANG') is not None and os.path.isfile(d.getVar('MANIFEST_PATH_META_CLANG') + '/conf/layer.conf') else ''}" |
There was a problem hiding this comment.
The PR description mentions "compiler version 1.72.0", but 1.72.0 is a Rust compiler version, not a clang version. Meta-clang provides the LLVM clang compiler toolchain, not Rust. If secclient-rs requires Rust 1.72.0, this should be clarified. Additionally, meta-clang typically requires specific dependencies and layer ordering (it often needs to come early in BBLAYERS, before layers that might use it). Placing it at the end of the configuration file may cause build issues if other layers need to use clang as their compiler.
jcarrete5
force-pushed
the
feature/RDKOSS-578
branch
from
7123cf0 to
b15d96b
Compare
Reason for change: The clang compiler is required for the secclient-rs module. This commit integrates the meta-clang recipe, which provides compiler version 1.72.0. Signed-off-by: mselva006c <mani_selvaraj@comcast.com>
jcarrete5
force-pushed
the
feature/RDKOSS-578
branch
from
b15d96b to
07b5acc
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maniselva006c
changed the title
Reason for change:
The clang compiler is required for the secclient-rs module. This commit integrates the meta-clang recipe, which provides compiler version 1.72.0.