Skip to content

RDKEMW-12842: Include meta-clang needed for secclient-rs #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdkcm-rdke merged 3 commits into from
Jan 27, 2026
Merged

RDKEMW-12842: Include meta-clang needed for secclient-rs #424

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07b5acc
RDKOSS-578: Include meta-clang needed for secclient-rs
Dec 20, 2025
9ce4835
Merge branch 'develop' into feature/RDKOSS-578
maniselva006c Jan 22, 2026
b3ff912
Merge branch 'develop' into feature/RDKOSS-578
anand-ky Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions conf/template/bblayers.conf.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,4 @@ BBLAYERS =+ " \
${@d.getVar('MANIFEST_PATH_REGION_CONFIG') if d.getVar('MANIFEST_PATH_REGION_CONFIG') is not None and os.path.isfile(d.getVar('MANIFEST_PATH_REGION_CONFIG') + '/conf/layer.conf') else ''} \
"
BBLAYERS =+ "${@d.getVar('MANIFEST_PATH_META_MIXIN') if d.getVar('MANIFEST_PATH_META_MIXIN') is not None and os.path.isfile(d.getVar('MANIFEST_PATH_META_MIXIN') + '/conf/layer.conf') else ''}"
BBLAYERS =+ "${@d.getVar('MANIFEST_PATH_META_CLANG') if d.getVar('MANIFEST_PATH_META_CLANG') is not None and os.path.isfile(d.getVar('MANIFEST_PATH_META_CLANG') + '/conf/layer.conf') else ''}"
Copy link

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description mentions "compiler version 1.72.0", but 1.72.0 is a Rust compiler version, not a clang version. Meta-clang provides the LLVM clang compiler toolchain, not Rust. If secclient-rs requires Rust 1.72.0, this should be clarified. Additionally, meta-clang typically requires specific dependencies and layer ordering (it often needs to come early in BBLAYERS, before layers that might use it). Placing it at the end of the configuration file may cause build issues if other layers need to use clang as their compiler.

Copilot uses AI. Check for mistakes.