API Compare Dashboard Report #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbat
commented
Nov 3, 2024
lib/superset/request.rb
Outdated
|
|
||
| def order_by | ||
| # by default, we will order by changed_on as per the GUI | ||
| ",order_column:changed_on,order_direction:desc" |
There was a problem hiding this comment.
this default value is removed in a later commit that sets default to nil
as unfortunately Superset does not have a consistent naming convention for changed_on date
so we can not use this across all child classes
jbat
force-pushed
the
NEP-18768-create-dashboard-report
branch
from
00b07f5 to
2c89619
Compare
soundarya-mv
reviewed
Apr 3, 2025
| end | ||
|
|
||
| # add ERROR msg if multiple chart dataset schemas are found, ie all datasets should be sourced from the same db schema | ||
| chart_dataset_schemas = dashboard[:datasets][:chart_datasets].map{|d| d[:schema]}.uniq |
There was a problem hiding this comment.
Should we also include the filter datasets here to see if filter dataset schema is different from chart dataset schema ?
There was a problem hiding this comment.
@soundarya-mv nice pickup, and yes we should.
see last commit
soundarya-mv
reviewed
Apr 4, 2025
| @data_sovereignty_issues ||= begin | ||
| @report.map do |dashboard| | ||
| reasons = [] | ||
| chart_dataset_ids = dashboard[:datasets][:chart_datasets].map{|d| d[:id]} |
There was a problem hiding this comment.
If chart_datasets also contains filter_datasets, then won't the below condition be false always ?
jbat
changed the title
jbat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jobready.atlassian.net/browse/NEP-18768
Example