Changes to htmlwidgets vignette #7
Merged
+142
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rn how to create a binding
cpsievert
commented
Jan 12, 2019
| ) | ||
| ======= | ||
| reactWidget('reactSparklines', 'output', SparklinesComponents, {}); | ||
| ``` |
There was a problem hiding this comment.
@alandipert I don't think your addition here was intentional?
There was a problem hiding this comment.
It wasn't, but fixed on enhancements 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branches off #4 (i.e., 9983058 is really the only relevant thing here). Feel free to use as much or as little as you like @alandipert :)
Also, some of these changes do intentionally suggests some small and subtle changes to the scaffolding template for the purpose of a better explanation.
I did this fairly quickly, so if you want to adopt it, we should spend some time proofreading and polishing.