Skip to content

Changes to htmlwidgets vignette #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2019
Merged

Changes to htmlwidgets vignette #7

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9983058
Make vignette more geared towards an R user that wants to quickly lea…
cpsievert Jan 12, 2019
5c2e639
Merge branch 'enhancements' into htmlwidgets-vignette
alandipert Jan 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions vignettes/intro_htmlwidgets.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ To create a new widget you can call `scaffoldReactWidget` to generate the basic
The following R code will create a package named **sparklines**, then provide the templating for creating an htmlwidget powered by the `react-sparklines` npm package:

```{r}
# Set the current working directory to your home directory. The new widget will
# be created in ~/sparklines
setwd("~")
# Create a directory 'sparklines' and populate it with skeletal package
# If run within RStudio, this will create a new RStudio session
usethis::create_package("sparklines")
Expand Down Expand Up @@ -120,6 +123,8 @@ data = sampleData,
sparklinesLine(color = "#56b45d"),
sparklinesSpots(style = list(fill = "#56b45d"))
)
=======
reactWidget('reactSparklines', 'output', SparklinesComponents, {});
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alandipert I don't think your addition here was intentional?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't, but fixed on enhancements 👍


The following sections show how to implement this R interface from our scaffolded widget.
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.