Skip to content

internal: Remove unused actions/cache from benchmark workflows #3797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntucker merged 1 commit into from
Mar 20, 2026
Merged

internal: Remove unused actions/cache from benchmark workflows #3797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions .github/workflows/benchmark-react.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,18 +55,11 @@ jobs:
cd examples/benchmark-react && yarn bench | tee react-bench-output.json

# PR comments on changes
- name: Download previous benchmark data (PR)
if: ${{ github.event_name == 'pull_request' }}
uses: actions/cache@v5
with:
path: ./cache
key: ${{ runner.os }}-benchmark-react-pr-${{ github.run_number }}
restore-keys: |
${{ runner.os }}-benchmark-react
- name: Store benchmark result (PR)
if: ${{ github.event_name == 'pull_request' }}
uses: rhysd/github-action-benchmark@v1
with:
name: 'Benchmark React'
Copy link
Copy Markdown

@cursor cursor bot Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing benchmark name breaks historical data comparison

Medium Severity

The name parameter in rhysd/github-action-benchmark serves as both the PR comment header and the key for storing/retrieving benchmark data in the JSON file on the gh-pages-bench branch. All existing historical data is stored under the default key "Benchmark". Changing it to "Benchmark React" means the action won't find any historical entries to compare against, breaking PR benchmark comparisons and losing trend continuity until new data accumulates under the new key.

Additional Locations (1)
Fix in Cursor Fix in Web

tool: 'customSmallerIsBetter'
output-file-path: examples/benchmark-react/react-bench-output.json
github-token: "${{ secrets.GITHUB_TOKEN }}"
Expand All @@ -80,16 +73,11 @@ jobs:
auto-push: false

# master reports to history
- name: Download previous benchmark data (main)
if: ${{ github.event_name == 'push' }}
uses: actions/cache@v5
with:
path: ./cache
key: ${{ runner.os }}-benchmark-react
- name: Store benchmark result (main)
if: ${{ github.event_name == 'push' }}
uses: rhysd/github-action-benchmark@v1
with:
name: 'Benchmark React'
tool: 'customSmallerIsBetter'
output-file-path: examples/benchmark-react/react-bench-output.json
github-token: "${{ secrets.GITHUB_TOKEN }}"
Expand Down
17 changes: 0 additions & 17 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,7 @@ jobs:
- name: Run benchmark
run: yarn workspace example-benchmark start | tee output.txt


# PR comments on changes
- name: Download previous benchmark data (PR)
if: ${{ github.event_name == 'pull_request' }}
uses: actions/cache@v5
with:
path: ./cache
key: ${{ runner.os }}-benchmark-pr-${{ github.run_number }}
restore-keys: |
${{ runner.os }}-benchmark
- name: Store benchmark result (PR)
if: ${{ github.event_name == 'pull_request' }}
uses: rhysd/github-action-benchmark@v1
Expand All @@ -65,22 +56,14 @@ jobs:
output-file-path: output.txt
github-token: "${{ secrets.GITHUB_TOKEN }}"
gh-pages-branch: 'gh-pages-bench'
# Show alert with commit comment on detecting possible performance regression
alert-threshold: '150%'
comment-always: true
fail-on-alert: false
alert-comment-cc-users: '@ntucker'
# we only want to compare against master, so do not save for PR
save-data-file: false
auto-push: false

# master reports to history
- name: Download previous benchmark data (main)
if: ${{ github.event_name == 'push' }}
uses: actions/cache@v5
with:
path: ./cache
key: ${{ runner.os }}-benchmark
- name: Store benchmark result (main)
if: ${{ github.event_name == 'push' }}
uses: rhysd/github-action-benchmark@v1
Expand Down
Loading