internal: Remove unused actions/cache from benchmark workflows#3797
internal: Remove unused actions/cache from benchmark workflows#3797
Conversation
The rhysd/github-action-benchmark action fetches data directly from gh-pages-bench branch — the actions/cache steps were never used. Also set name: 'Benchmark React' so PR comments are distinguishable. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| if: ${{ github.event_name == 'pull_request' }} | ||
| uses: rhysd/github-action-benchmark@v1 | ||
| with: | ||
| name: 'Benchmark React' |
There was a problem hiding this comment.
Changing benchmark name breaks historical data comparison
Medium Severity
The name parameter in rhysd/github-action-benchmark serves as both the PR comment header and the key for storing/retrieving benchmark data in the JSON file on the gh-pages-bench branch. All existing historical data is stored under the default key "Benchmark". Changing it to "Benchmark React" means the action won't find any historical entries to compare against, breaking PR benchmark comparisons and losing trend continuity until new data accumulates under the new key.
Additional Locations (1)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 0189a8f | Previous: 3d7a577 | Ratio |
|---|---|---|---|
normalizeLong |
460 ops/sec (±0.90%) |
440 ops/sec (±0.97%) |
0.96 |
normalizeLong Values |
421 ops/sec (±0.14%) |
406 ops/sec (±0.41%) |
0.96 |
denormalizeLong |
298 ops/sec (±2.20%) |
277 ops/sec (±3.29%) |
0.93 |
denormalizeLong Values |
269 ops/sec (±2.24%) |
265 ops/sec (±2.15%) |
0.99 |
denormalizeLong donotcache |
1032 ops/sec (±0.19%) |
1021 ops/sec (±0.08%) |
0.99 |
denormalizeLong Values donotcache |
774 ops/sec (±0.16%) |
775 ops/sec (±0.36%) |
1.00 |
denormalizeShort donotcache 500x |
1617 ops/sec (±0.15%) |
1606 ops/sec (±0.14%) |
0.99 |
denormalizeShort 500x |
849 ops/sec (±2.24%) |
873 ops/sec (±2.00%) |
1.03 |
denormalizeShort 500x withCache |
6176 ops/sec (±0.12%) |
6542 ops/sec (±0.19%) |
1.06 |
queryShort 500x withCache |
2769 ops/sec (±0.13%) |
2790 ops/sec (±0.08%) |
1.01 |
buildQueryKey All |
54572 ops/sec (±0.37%) |
55220 ops/sec (±0.40%) |
1.01 |
query All withCache |
6435 ops/sec (±0.20%) |
7335 ops/sec (±0.27%) |
1.14 |
denormalizeLong with mixin Entity |
280 ops/sec (±1.89%) |
281 ops/sec (±2.15%) |
1.00 |
denormalizeLong withCache |
6979 ops/sec (±0.63%) |
7040 ops/sec (±0.15%) |
1.01 |
denormalizeLong Values withCache |
5160 ops/sec (±0.35%) |
5192 ops/sec (±0.24%) |
1.01 |
denormalizeLong All withCache |
6144 ops/sec (±0.16%) |
7201 ops/sec (±0.15%) |
1.17 |
denormalizeLong Query-sorted withCache |
6333 ops/sec (±0.11%) |
7526 ops/sec (±0.95%) |
1.19 |
denormalizeLongAndShort withEntityCacheOnly |
1703 ops/sec (±0.75%) |
1710 ops/sec (±0.18%) |
1.00 |
getResponse |
4671 ops/sec (±0.44%) |
4798 ops/sec (±0.95%) |
1.03 |
getResponse (null) |
10163083 ops/sec (±1.25%) |
10363848 ops/sec (±1.12%) |
1.02 |
getResponse (clear cache) |
272 ops/sec (±2.23%) |
265 ops/sec (±2.15%) |
0.97 |
getSmallResponse |
3406 ops/sec (±0.17%) |
3445 ops/sec (±0.08%) |
1.01 |
getSmallInferredResponse |
2532 ops/sec (±0.10%) |
2554 ops/sec (±0.14%) |
1.01 |
getResponse Collection |
4600 ops/sec (±0.34%) |
4753 ops/sec (±0.54%) |
1.03 |
get Collection |
4650 ops/sec (±0.19%) |
4724 ops/sec (±0.25%) |
1.02 |
get Query-sorted |
5263 ops/sec (±0.14%) |
5449 ops/sec (±0.52%) |
1.04 |
setLong |
469 ops/sec (±0.25%) |
452 ops/sec (±0.33%) |
0.96 |
setLongWithMerge |
263 ops/sec (±0.12%) |
258 ops/sec (±0.18%) |
0.98 |
setLongWithSimpleMerge |
278 ops/sec (±0.14%) |
275 ops/sec (±0.15%) |
0.99 |
setSmallResponse 500x |
947 ops/sec (±0.36%) |
944 ops/sec (±0.94%) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3797 +/- ##
=========================================
Coverage ? 98.06%
=========================================
Files ? 151
Lines ? 2843
Branches ? 556
=========================================
Hits ? 2788
Misses ? 11
Partials ? 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
Motivation
The
actions/cachesteps in bothbenchmark.ymlandbenchmark-react.ymlwere never used —rhysd/github-action-benchmarkfetches historical data directly from thegh-pages-benchbranch via git. The cache steps wrote to/read from./cachewhich nothing referenced, producing "Cache not found" noise in CI logs.Additionally, the benchmark-react PR comment header showed "Benchmark" (the default) making it indistinguishable from the Node benchmark comment.
Solution
actions/cachesteps from both benchmark workflows (4 steps total)name: 'Benchmark React'to the react benchmark action so PR comments have a distinct headerOpen questions
N/A
Made with Cursor
Note
Low Risk
Low risk CI-only change that only adjusts workflow steps and benchmark action metadata. Main impact is on benchmark job logging/comments rather than production code.
Overview
Removes the unused
actions/cache“Download previous benchmark data” steps from both benchmark workflows, reducing CI noise and simplifying runs.Updates the React benchmark reporting to set an explicit
name: 'Benchmark React'forrhysd/github-action-benchmark, making PR comments/history entries distinguishable from the Node benchmark.Written by Cursor Bugbot for commit 0189a8f. This will update automatically on new commits. Configure here.