Fix for required keyword on partial properties #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennawatson
approved these changes
Mar 16, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix for #208
What is the current behavior?
#208
What is the new behavior?
This pull request introduces changes to the ReactiveUI source generators to support the
UseRequiredattribute for properties. The most important changes include adding a new property with theUseRequiredattribute, updating the generator to handle the new attribute, and modifying the property syntax generation to include therequiredkeyword when applicable.Support for
UseRequiredattribute:src/ReactiveUI.SourceGenerators.Execute/TestViewModel.cs: Added a new propertyPartialRequiredPropertyTestwith theUseRequiredattribute set to true.Generator updates:
src/ReactiveUI.SourceGenerators.Roslyn/Reactive/ReactiveGenerator.Execute.cs: Updated theReactiveGeneratorclass to parse theUseRequiredattribute and use it when generating property code.Property syntax generation:
src/ReactiveUI.SourceGenerators.Roslyn/Reactive/ReactiveGenerator.Execute.cs: Modified theGetPropertySyntaxmethod to include therequiredkeyword in the generated property syntax when theUseRequiredattribute is present.What might this PR break?
None as code generation would have failed when used in this manner
Please check if the PR fulfills these requirements
Other information: