Skip to content

Fix for required keyword on partial properties #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glennawatson merged 1 commit into from
Mar 16, 2025
Merged

Fix for required keyword on partial properties #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/ReactiveUI.SourceGenerators.Execute/TestViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,15 @@ public TestViewModel()
[Reactive]
public partial string? PartialPropertyTest { get; set; }

/// <summary>
/// Gets or sets the partial property test.
/// </summary>
/// <value>
/// The partial property test.
/// </value>
[Reactive(UseRequired = true)]
public required partial string? PartialRequiredPropertyTest { get; set; }

/// <summary>
/// Gets the internal test property. Should not prompt to replace with INPC Reactive Property.
/// </summary>
Expand Down
7 changes: 5 additions & 2 deletions src/ReactiveUI.SourceGenerators.Roslyn/Reactive/ReactiveGenerator.Execute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,10 @@ public sealed partial class ReactiveGenerator
token.ThrowIfCancellationRequested();

var inheritance = propertySymbol.IsVirtual ? " virtual" : propertySymbol.IsOverride ? " override" : string.Empty;
var useRequired = string.Empty;

attributeData.TryGetNamedArgument("UseRequired", out bool useRequiredArgument);
var useRequired = useRequiredArgument ? "required " : string.Empty;

var typeNameWithNullabilityAnnotations = propertySymbol.Type.GetFullyQualifiedNameWithNullabilityAnnotations();
var fieldName = propertySymbol.GetGeneratedFieldName();
var propertyName = propertySymbol.Name;
Expand Down Expand Up @@ -326,7 +329,7 @@ private static string GetPropertySyntax(PropertyInfo propertyInfo)
{{fieldSyntax}}
/// <inheritdoc cref="{{fieldName}}"/>
{{propertyAttributes}}
{{propertyInfo.TargetInfo.TargetVisibility}}{{propertyInfo.Inheritance}} {{partialModifier}}{{propertyInfo.UseRequired}}{{propertyInfo.TypeNameWithNullabilityAnnotations}} {{propertyInfo.PropertyName}}
{{propertyInfo.TargetInfo.TargetVisibility}}{{propertyInfo.Inheritance}} {{propertyInfo.UseRequired}}{{partialModifier}}{{propertyInfo.TypeNameWithNullabilityAnnotations}} {{propertyInfo.PropertyName}}
{
get => {{propertyInfo.FieldName}};
[global::System.Diagnostics.CodeAnalysis.MemberNotNull("{{fieldName}}")]
Expand Down
Loading