[RAPPS-DB] Set Chrome no-sandbox parameter on shortcut and other x64 fixes #321
Conversation
| Installer = Generate | ||
|
|
||
| [Section.amd64] | ||
| URLDownload = https://web.archive.org/web/20170803195021/https://download.sysinternals.com/files/Autoruns.zip |
There was a problem hiding this comment.
Add SHA1 for it? Also, isn't it an unrelated change? (as well as some others)
There was a problem hiding this comment.
UPD: I've re-read the description, that's ok, but question for SHA1 still stands.
There was a problem hiding this comment.
The download is the same as for x86 and it gets the hash from the main section. The URL just needs to be listed again under Section.amd64 for Rapps to accept it. There is no AnyCPU concept.
And yes, these others are unrelated to Chrome but they are x64 fixes.
There was a problem hiding this comment.
There is no AnyCPU concept
It cannot fallback to the [Section] in that case?
There was a problem hiding this comment.
It doesn't right now. And if the main x86 is still the main arch that we maintain (and we still don't have WOW64 or others), IMHO it would stay like that.
There was a problem hiding this comment.
It cannot fallback to the
[Section]in that case?
No. All values except the download URL will fallback to the non-CPU section but rapps has special code to not accept the URL on non-x86 (this restriction will probably removed when we get wow64).
| [Section.arm64] | ||
| URLDownload = https://web.archive.org/web/20210503071949/http://download.sysinternals.com/Files/ZoomIt.zip |
There was a problem hiding this comment.
Uhm... Do we have a bootable reactos compatible ARM64 and I didn't noticed? xD
Nah, it's a joke, if you consider to add it here, I am not against. Rapps-db must be a trusty database itself, even for the future.
There was a problem hiding this comment.
Same question as for the other file.
julenuri
left a comment
julenuri
left a comment
There was a problem hiding this comment.
Approved, just fix a little the PR title to fit more to the proposal of the PR, Chrome and other x64 software fixing. Thanks.
| Installer = Generate | ||
|
|
||
| [Section.amd64] | ||
| URLDownload = https://web.archive.org/web/20170803195021/https://download.sysinternals.com/files/Autoruns.zip |
There was a problem hiding this comment.
There is no AnyCPU concept
It cannot fallback to the [Section] in that case?
| [Section.amd64] | ||
| URLDownload = https://web.archive.org/web/20221116090816/https://download.sysinternals.com/files/TCPView.zip | ||
|
|
||
| [Section.arm64] |
There was a problem hiding this comment.
Adding ARM64 for here, but not the other apps?! 👀
There was a problem hiding this comment.
I know a couple of these sysinternals tools ship all 3 in the same zip file and I had already done part of the work needed, just didn't know it needed this extra download value (obviously I only tested this on x64, not on arm).
For Process Explorer. We are stuck with an old version that never shipped arm64.
There was a problem hiding this comment.
ah OK, makes sense if the zip contains an ARM64 build too.
| [Section.arm64] | ||
| URLDownload = https://web.archive.org/web/20210503071949/http://download.sysinternals.com/Files/ZoomIt.zip |
There was a problem hiding this comment.
Same question as for the other file.
| Dir = %ProgramFiles%\Google\Chrome | ||
| Lnk = "Google Chrome.lnk" | ||
| Files = chrome48\Chrome-bin\*.exe|chrome48\Chrome-bin\* | ||
| Dir = Google\Chrome |
There was a problem hiding this comment.
When nothing else is prepended, this falls back to ProgramFiles by default?
There was a problem hiding this comment.
No, with no % at the root, Rapps will install to %localappdata% or %programfiles% in the future but now it's just for the user. There technically is some support for setting Scope=Machine in the manifest to force %programfiles% but I don't want to do that here (official Chrome also installs for the user). I want Rapps to give you the option to set a default user/machine preference when the package does not have a hard requirement. This has not been done yet, UAC considerations must be thought through first.
| Lnk = "Google Chrome.lnk" | ||
| Files = chrome48\Chrome-bin\*.exe|chrome48\Chrome-bin\* | ||
| Dir = Google\Chrome | ||
| Lnk = Google Chrome.lnk |
There was a problem hiding this comment.
Keep this inside quotes? (the file name contains spaces)
There was a problem hiding this comment.
This is not a command line and neither the spec not implementation expects quotes, the ini parser must be stripping them by chance.
There was a problem hiding this comment.
It's not "by chance" that the ini parser strips them; this is part of the spec.
https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getprivateprofilestringw#remarks
If the string associated with lpKeyName is enclosed in single or double quotation marks, the marks are discarded when the GetPrivateProfileString function retrieves the string.
There was a problem hiding this comment.
Just be careful with this, parts of Rapps uses the Setup API inf parser.
There was a problem hiding this comment.
Ok then the quotes in the string values will definitely be stripped away.
whindsaks
changed the title
| Installer = Generate | ||
|
|
||
| [Section.amd64] | ||
| URLDownload = https://web.archive.org/web/20190913041012/https://download.sysinternals.com/files/ProcessExplorer.zip |
There was a problem hiding this comment.
Maybe some magic key like inherit or so would be nice here?
There was a problem hiding this comment.
Assuming Wow64 is far away then yes, this would be pretty nice. If we would still want to respect the localization sections then it will be a bit painful but I think I can make a GetSectionStringEx that lets you skip the CPU bits. I don't know how common this .zip style distribution with the same URL is though...
5 participants
Fixes Chrome on x64 (x86 uses a different installer we can't fix this way).
Notes: