Skip to content

[RAPPS-DB] Set Chrome no-sandbox parameter on shortcut and other x64 fixes #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whindsaks merged 1 commit into from
Jul 18, 2025
Merged

[RAPPS-DB] Set Chrome no-sandbox parameter on shortcut and other x64 fixes #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/validate-rapps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
b'Files',
b'Dir',
b'Lnk',
b'LnkParameters',
b'Icon',
b'DelFile',
b'DelDir',
Expand Down
3 changes: 3 additions & 0 deletions autoruns.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ SHA1 = 62c0af2d62d58aa51650f1bf23d0222d43bf9bb1
SizeBytes = 1305367
Installer = Generate

[Section.amd64]
URLDownload = https://web.archive.org/web/20170803195021/https://download.sysinternals.com/files/Autoruns.zip
Copy link
Member

@binarymaster binarymaster Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add SHA1 for it? Also, isn't it an unrelated change? (as well as some others)

Copy link
Member

@binarymaster binarymaster Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPD: I've re-read the description, that's ok, but question for SHA1 still stands.

Copy link
Contributor Author

@whindsaks whindsaks Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The download is the same as for x86 and it gets the hash from the main section. The URL just needs to be listed again under Section.amd64 for Rapps to accept it. There is no AnyCPU concept.

And yes, these others are unrelated to Chrome but they are x64 fixes.

Copy link
Contributor

@HBelusca HBelusca Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no AnyCPU concept

It cannot fallback to the [Section] in that case?

Copy link
Collaborator

@julenuri julenuri Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't right now. And if the main x86 is still the main arch that we maintain (and we still don't have WOW64 or others), IMHO it would stay like that.

Copy link
Contributor Author

@whindsaks whindsaks Jul 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It cannot fallback to the [Section] in that case?

No. All values except the download URL will fallback to the non-CPU section but rapps has special code to not accept the URL on non-x86 (this restriction will probably removed when we get wow64).

https://github.com/reactos/reactos/blob/49e652b7b790de896e63b4de07822376f4d627f0/base/applications/rapps/configparser.cpp#L75


[Generate]
Files = *s.exe|*sc.exe|*.chm
Dir = SysInternals\AutoRuns
Expand Down
10 changes: 8 additions & 2 deletions chrome_48.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,11 @@ Installer = Generate
Description = Google Chrome es el popular navegador web de código cerrado​ desarrollado por Google, derivado del proyecto Chromium.

[Generate]
Dir = %ProgramFiles%\Google\Chrome
Lnk = "Google Chrome.lnk"
Files = chrome48\Chrome-bin\*.exe|chrome48\Chrome-bin\*
Dir = Google\Chrome
Copy link
Contributor

@HBelusca HBelusca Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When nothing else is prepended, this falls back to ProgramFiles by default?

Copy link
Contributor Author

@whindsaks whindsaks Jul 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, with no % at the root, Rapps will install to %localappdata% or %programfiles% in the future but now it's just for the user. There technically is some support for setting Scope=Machine in the manifest to force %programfiles% but I don't want to do that here (official Chrome also installs for the user). I want Rapps to give you the option to set a default user/machine preference when the package does not have a hard requirement. This has not been done yet, UAC considerations must be thought through first.

Lnk = Google Chrome.lnk
Copy link
Contributor

@HBelusca HBelusca Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this inside quotes? (the file name contains spaces)

Copy link
Contributor Author

@whindsaks whindsaks Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a command line and neither the spec not implementation expects quotes, the ini parser must be stripping them by chance.

Copy link
Contributor

@HBelusca HBelusca Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not "by chance" that the ini parser strips them; this is part of the spec.
https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getprivateprofilestringw#remarks

If the string associated with lpKeyName is enclosed in single or double quotation marks, the marks are discarded when the GetPrivateProfileString function retrieves the string.

Copy link
Contributor Author

@whindsaks whindsaks Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just be careful with this, parts of Rapps uses the Setup API inf parser.

Copy link
Contributor

@HBelusca HBelusca Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then the quotes in the string values will definitely be stripped away.

LnkParameters = --no-sandbox
DelFile = debug.log
DelDir = Dictionaries
DelDirEmpty = .|..
DelReg = HKCU\Software\Google\Chrome\BLBeacon
3 changes: 3 additions & 0 deletions processexplorer.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ SHA1 = 6c0237823163ba0e7b525e2f68c881d983a554af
SizeBytes = 2004933
Installer = Generate

[Section.amd64]
URLDownload = https://web.archive.org/web/20190913041012/https://download.sysinternals.com/files/ProcessExplorer.zip
Copy link
Member

@learn-more learn-more Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some magic key like inherit or so would be nice here?

Copy link
Contributor Author

@whindsaks whindsaks Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming Wow64 is far away then yes, this would be pretty nice. If we would still want to respect the localization sections then it will be a bit painful but I think I can make a GetSectionStringEx that lets you skip the CPU bits. I don't know how common this .zip style distribution with the same URL is though...


[Generate]
Files = procexp.exe|*.chm
Dir = SysInternals\Process Explorer
Expand Down
3 changes: 3 additions & 0 deletions siv.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ SizeBytes = 23685583
Screenshot1 = https://github.com/user-attachments/assets/a9b348da-2ce0-4afd-9bc1-a8f6ce5278f8
Installer = Generate

[Section.amd64]
URLDownload = https://delivery2.filecroco.com/kits_6/siv_v5.80.zip

[Generate]
Files = SIV32X.exe|*
DelReg = HKCU\Software\SIV|HKLM\Software\SIV
Expand Down
6 changes: 6 additions & 0 deletions tcpview.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ URLDownload = https://web.archive.org/web/20210319143650/https://download.sysint
SHA1 = 169cec73efc0edfcc0081f0a1ed09b70fe7a947b
SizeBytes = 291606

[Section.amd64]
URLDownload = https://web.archive.org/web/20221116090816/https://download.sysinternals.com/files/TCPView.zip

[Section.arm64]
Copy link
Contributor

@HBelusca HBelusca Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding ARM64 for here, but not the other apps?! 👀

Copy link
Contributor Author

@whindsaks whindsaks Jul 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know a couple of these sysinternals tools ship all 3 in the same zip file and I had already done part of the work needed, just didn't know it needed this extra download value (obviously I only tested this on x64, not on arm).

For Process Explorer. We are stuck with an old version that never shipped arm64.

Copy link
Contributor

@HBelusca HBelusca Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah OK, makes sense if the zip contains an ARM64 build too.

URLDownload = https://web.archive.org/web/20221116090816/https://download.sysinternals.com/files/TCPView.zip

[Generate]
Files = *view.exe|tcp*
Dir = SysInternals\TCPView
Expand Down
2 changes: 1 addition & 1 deletion windbg.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Name = WinDbg
Version = 6.12.0002.633
LicenseType = 2
Description = WinDbg is a multipurpose debugger for the Microsoft Windows computer operating system, distributed by Microsoft.
Category = 12
Category = 7
Publisher = Microsoft
URLSite = https://web.archive.org/web/20110221133326/https://www.microsoft.com/whdc/devtools/debugging/installx86.mspx
URLDownload = https://download.microsoft.com/download/A/6/A/A6AC035D-DA3F-4F0C-ADA4-37C8E5D34E3D/setup/WinSDKDebuggingTools/dbg_x86.msi
Expand Down
6 changes: 6 additions & 0 deletions zoomit.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ SHA1 = 231a7f6ee113f71f2f0e7a7cef0931c27f23501f
SizeBytes = 939781
Installer = Generate

[Section.amd64]
URLDownload = https://web.archive.org/web/20210503071949/http://download.sysinternals.com/Files/ZoomIt.zip

[Section.arm64]
URLDownload = https://web.archive.org/web/20210503071949/http://download.sysinternals.com/Files/ZoomIt.zip
Comment on lines +18 to +19
Copy link
Collaborator

@julenuri julenuri Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm... Do we have a bootable reactos compatible ARM64 and I didn't noticed? xD
Nah, it's a joke, if you consider to add it here, I am not against. Rapps-db must be a trusty database itself, even for the future.

Copy link
Contributor

@HBelusca HBelusca Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as for the other file.


[Generate]
Files = *it.exe
Dir = SysInternals\ZoomIt
Expand Down