Merged
Conversation
so we can see the help screen!
kanadgupta
added
refactor
erunion
approved these changes
Feb 27, 2025
| rdme: help | ||
|
|
||
| - name: Assert that previous step failed | ||
| if: ${{ steps.help-fail.outcome == 'failure' }} |
| @@ -1,11 +1,10 @@ | |||
| // @ts-check | |||
Contributor
Author
There was a problem hiding this comment.
it requires installing a whole add'l dependency so i opted not to: https://rollupjs.org/command-line-interface/#config-intellisense
kanadgupta
added
the
needs-backport-to-v9
kanadgupta
added a commit
that referenced
this pull request
Feb 28, 2025
## 🧰 Changes [node v20.18.3](https://nodejs.org/en/blog/release/v20.18.3) officially marked import attributes [as stable](https://nodejs.org/docs/latest-v20.x/api/esm.html#import-attributes). we have a lot of weird workarounds with our `oclif` setup in this repo in an effort to avoid import attributes and the ugly `ExperimentalWarning` outputs we see, but i don't think those should be a concern anymore, for a few reasons: - our minimum required node.js version is node 20, so it should be a non-disruptive change for users to upgrade to the latest node 20 channel - even if folks are on <20.18.2, the `ExperimentalWarning` outputs log to `stderr` so it shouldn't affect any command output-based workflows, which almost always are relying on `stdout`. plus, we discourage this kind of scripting and recommend folks use exit codes instead given the above, this PR brings back JSON imports of `package.json` and vastly simplifies a lot of weirdness in this codebase. ## 🧬 QA & Testing we've added a lot of good test coverage now and i've been playing around with the CLI and github actions build locally and everything seems to work as expected. very unlikely we'll run into the fiasco in #1117, especially now with the cleanups in this PR and #1172.
Contributor
Author
|
🎉 This PR is included in version 10.2.0-next.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
kanadgupta
added a commit
that referenced
this pull request
Mar 19, 2025
a few small behind-the-scenes changes to simplify how we build `rdme` for GitHub Actions users — no actual customer impact here. quick breakdown of the changes: - [x] replaces `@rollup/plugin-terser` with `rollup-plugin-esbuild` for minifying our GitHub Actions code. the latter accomplishes basically the same result as the former, but in a tiny fraction of the time. - [x] we previously forked our GHA build process into a development vs. production setup since terser takes so long. since `rollup-plugin-esbuild` adds a negligible amount of time to our build process, there's no need to have two setups. this PR combines them into a single build process. - [x] added a bunch of steps to our CI to further assert that the GitHub Actions build is what we expect. does CI still pass?
kanadgupta
added a commit
that referenced
this pull request
Mar 19, 2025
## 🧰 Changes [node v20.18.3](https://nodejs.org/en/blog/release/v20.18.3) officially marked import attributes [as stable](https://nodejs.org/docs/latest-v20.x/api/esm.html#import-attributes). we have a lot of weird workarounds with our `oclif` setup in this repo in an effort to avoid import attributes and the ugly `ExperimentalWarning` outputs we see, but i don't think those should be a concern anymore, for a few reasons: - our minimum required node.js version is node 20, so it should be a non-disruptive change for users to upgrade to the latest node 20 channel - even if folks are on <20.18.2, the `ExperimentalWarning` outputs log to `stderr` so it shouldn't affect any command output-based workflows, which almost always are relying on `stdout`. plus, we discourage this kind of scripting and recommend folks use exit codes instead given the above, this PR brings back JSON imports of `package.json` and vastly simplifies a lot of weirdness in this codebase. ## 🧬 QA & Testing we've added a lot of good test coverage now and i've been playing around with the CLI and github actions build locally and everything seems to work as expected. very unlikely we'll run into the fiasco in #1117, especially now with the cleanups in this PR and #1172.
kanadgupta
added a commit
that referenced
this pull request
Mar 19, 2025
a few small behind-the-scenes changes to simplify how we build `rdme` for GitHub Actions users — no actual customer impact here. quick breakdown of the changes: - [x] replaces `@rollup/plugin-terser` with `rollup-plugin-esbuild` for minifying our GitHub Actions code. the latter accomplishes basically the same result as the former, but in a tiny fraction of the time. - [x] we previously forked our GHA build process into a development vs. production setup since terser takes so long. since `rollup-plugin-esbuild` adds a negligible amount of time to our build process, there's no need to have two setups. this PR combines them into a single build process. - [x] added a bunch of steps to our CI to further assert that the GitHub Actions build is what we expect. does CI still pass?
kanadgupta
added a commit
that referenced
this pull request
Mar 19, 2025
## 🧰 Changes [node v20.18.3](https://nodejs.org/en/blog/release/v20.18.3) officially marked import attributes [as stable](https://nodejs.org/docs/latest-v20.x/api/esm.html#import-attributes). we have a lot of weird workarounds with our `oclif` setup in this repo in an effort to avoid import attributes and the ugly `ExperimentalWarning` outputs we see, but i don't think those should be a concern anymore, for a few reasons: - our minimum required node.js version is node 20, so it should be a non-disruptive change for users to upgrade to the latest node 20 channel - even if folks are on <20.18.2, the `ExperimentalWarning` outputs log to `stderr` so it shouldn't affect any command output-based workflows, which almost always are relying on `stdout`. plus, we discourage this kind of scripting and recommend folks use exit codes instead given the above, this PR brings back JSON imports of `package.json` and vastly simplifies a lot of weirdness in this codebase. ## 🧬 QA & Testing we've added a lot of good test coverage now and i've been playing around with the CLI and github actions build locally and everything seems to work as expected. very unlikely we'll run into the fiasco in #1117, especially now with the cleanups in this PR and #1172.
kanadgupta
added
backported-to-v9
Contributor
Author
|
🎉 This PR is included in version 10.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
a few small behind-the-scenes changes to simplify how we build
rdmefor GitHub Actions users — no actual customer impact here. quick breakdown of the changes:@rollup/plugin-terserwithrollup-plugin-esbuildfor minifying our GitHub Actions code. the latter accomplishes basically the same result as the former, but in a tiny fraction of the time.rollup-plugin-esbuildadds a negligible amount of time to our build process, there's no need to have two setups. this PR combines them into a single build process.🧬 QA & Testing
does CI still pass?