chore(biome): incorporating our new common biome config#1307
Merged
kanadgupta merged 7 commits intonextfrom Jul 16, 2025
Merged
chore(biome): incorporating our new common biome config#1307kanadgupta merged 7 commits intonextfrom
kanadgupta merged 7 commits intonextfrom
Conversation
erunion
commented
Jul 15, 2025
erunion
commented
Jul 15, 2025
Comment on lines
26
to
+28
| "domains": { | ||
| // These domains are configured in our core standards package but Biome `extends` seems to | ||
| // not load it in so we have to redefine them. |
Member
Author
There was a problem hiding this comment.
Removing this domains config to rely on the one in the common config causes the useImportExtensions rule, which is enabled in domains.project, to stop being loaded:
$ npx biome check
bin/set-version-output.js:6:1 suppressions/unused ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
⚠ Suppression comment has no effect. Remove the suppression or make sure you are suppressing the correct rule.
4 │ import * as core from '@actions/core';
5 │
> 6 │ // biome-ignore lint/correctness/useImportExtensions: This file exists but Biome wants to use the `.d.ts` file instead.
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
7 │ import { getMajorPkgVersion, getNodeVersion } from '../dist/lib/getPkg.js';
8 │
Checked 92 files in 47ms. No fixes applied.
Found 1 warning.
kanadgupta
suggested changes
Jul 16, 2025
Comment on lines
26
to
+28
| "domains": { | ||
| // These domains are configured in our core standards package but Biome `extends` seems to | ||
| // not load it in so we have to redefine them. |
kanadgupta
suggested changes
Jul 16, 2025
Co-authored-by: Kanad Gupta <git@kanad.dev>
Co-authored-by: Kanad Gupta <git@kanad.dev>
Co-authored-by: Kanad Gupta <git@kanad.dev>
Co-authored-by: Kanad Gupta <git@kanad.dev>
Co-authored-by: Kanad Gupta <git@kanad.dev>
kanadgupta
approved these changes
Jul 16, 2025
Contributor
|
🎉 This PR is included in version 10.5.0-next.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
kanadgupta
added
released on @next
needs-backport-to-v9
Contributor
|
🎉 This PR is included in version 10.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This incorporates our new @readme/standards package for colocating our Prettier and Biome configs. Prettier was previously a part of
@readme/eslint-configbut as we're slowly beginning to move away from ESLint it makes sense to have this Prettier config decoupled from ESlint.