Skip to content

chore(biome): incorporating our new common biome config #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kanadgupta merged 7 commits into from
Jul 16, 2025
Merged

chore(biome): incorporating our new common biome config #1307

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
523464b
chore(biome): incorporating our new common biome config
erunion Jul 15, 2025
7f4f575
fix: pr feedback
erunion Jul 16, 2025
b4d72c5
Update bin/run.js
erunion Jul 16, 2025
cdf8679
Update bin/json-schema-store.js
erunion Jul 16, 2025
5dfb213
Update bin/set-version-output.js
erunion Jul 16, 2025
1e048e3
Update bin/set-major-version-tag.js
erunion Jul 16, 2025
b909f64
Update bin/dev.js
erunion Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/json-schema-store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,4 @@ async function refreshSchemas() {
}
}

refreshSchemas();
await refreshSchemas();
2 changes: 1 addition & 1 deletion bin/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ async function main() {
});
}

main();
await main();
2 changes: 1 addition & 1 deletion bin/set-major-version-tag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,4 +89,4 @@ async function setMajorVersionTag() {
}
}

setMajorVersionTag();
await setMajorVersionTag();
2 changes: 1 addition & 1 deletion bin/set-version-output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ async function setOutputs() {
core.setOutput('NODE_VERSION', getNodeVersion());
}

setOutputs();
await setOutputs();
32 changes: 3 additions & 29 deletions biome.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"$schema": "https://biomejs.dev/schemas/2.1.1/schema.json",
"root": true,
"extends": ["@readme/standards/biome"],
"vcs": {
"enabled": false,
"clientKind": "git",
Expand All @@ -22,19 +23,14 @@
"enabled": false,
},
"linter": {
"enabled": true,
"domains": {
// These domains are configured in our core standards package but Biome `extends` seems to
// not load it in so we have to redefine them.
Comment on lines 17 to +19
Copy link
Copy Markdown
Member Author

@erunion erunion Jul 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this domains config to rely on the one in the common config causes the useImportExtensions rule, which is enabled in domains.project, to stop being loaded:

$ npx biome check
bin/set-version-output.js:6:1 suppressions/unused ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ⚠ Suppression comment has no effect. Remove the suppression or make sure you are suppressing the correct rule.
  
    4 │ import * as core from '@actions/core';
    5 │ 
  > 6 │ // biome-ignore lint/correctness/useImportExtensions: This file exists but Biome wants to use the `.d.ts` file instead.
      │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    7 │ import { getMajorPkgVersion, getNodeVersion } from '../dist/lib/getPkg.js';
    8 │ 
  

Checked 92 files in 47ms. No fixes applied.
Found 1 warning.

Copy link
Copy Markdown
Contributor

@kanadgupta kanadgupta Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks i hate it

"project": "all",
"test": "all",
},
"rules": {
"recommended": true,
"correctness": {
// Don't warn about unused function parameters or recommend they're prefixed with an `_`.
"noUnusedFunctionParameters": "off",
},
"style": {
"noParameterAssign": "error",
"noRestrictedImports": {
"level": "error",
"options": {
Expand Down Expand Up @@ -64,26 +60,4 @@
},
},
},
"assist": {
"enabled": true,
"actions": {
"source": {
"organizeImports": {
"level": "on",
"options": {
// Import order: `type` -> Node builtins -> URL -> Package -> Local paths
"groups": [
{ "type": true },
":BLANK_LINE:", // We add blank lines between the groups to improve readability.
{ "source": [":BUN:", ":NODE:"] },
":BLANK_LINE:",
{ "source": [":URL", ":PACKAGE:", ":PACKAGE_WITH_PROTOCOL:"] },
":BLANK_LINE:",
":PATH:",
],
},
},
},
},
},
}
Loading
Loading