Conversation
| project?: string; | ||
| } { | ||
| const apiKey = (() => { | ||
| switch (true) { |
There was a problem hiding this comment.
these switch(true) statements were pretty clunky and unreadable and biome didn't like 'em so i opted to simplify them.
| const val = opts[flag]; | ||
| // obfuscate the key in a GitHub secret | ||
| if (flag === 'key') return `--key=$\{{ secrets.${GITHUB_SECRET_NAME} }}`; | ||
| if (flag === 'key') return `--key=\${{ secrets.${GITHUB_SECRET_NAME} }}`; |
There was a problem hiding this comment.
biome was flagging this as an unnecessary escape character but i don't think that's true, but this harmless little tweak silenced the error 🤷🏽
There was a problem hiding this comment.
I'm actually surprised the former works, but I verified that both do
There was a problem hiding this comment.
yeah i think the updated escape sequencing is technically a bit better
| let unsortedFiles = await findPages.call(this, pathInput); | ||
|
|
||
| let transformedByHooks = false; | ||
| let transformedByHooks: boolean = false; |
There was a problem hiding this comment.
for some reason TS thinks this was false without this type instantiation, which caused biome to flag an if-statement further down below. not sure who to blame here (TS or biome), but this fixed it 🤷🏽
| async function main() { | ||
| const { execute } = await import('@oclif/core'); | ||
| await execute({ development: true, dir: import.meta.url }).then(msg => { | ||
| // biome-ignore lint/nursery/noUnnecessaryConditions: this is a false positive, biome is clowning for this |
There was a problem hiding this comment.
there are a handful of false positives with this lint/nursery/noUnnecessaryConditions rule that started cropping up. i decided to individually ignore them since i imagine biome will fix these quirks over time and we can remove these ignore statements once that happens.
There was a problem hiding this comment.
I ended up turning this rule off in our shared config because it's so buggy but I haven't shipped a release of that yet.
There was a problem hiding this comment.
cool, i'll leave these as is for now until we do that
kanadgupta
added
the
needs-backport-to-v9
|
🎉 This PR is included in version 10.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
🧰 Changes
before:
after:
also resolves an issue from chalk/chalk#656