-
Notifications
You must be signed in to change notification settings - Fork 48
chore(deps): bump #1343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump #1343
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,7 +86,7 @@ export default class DocsMigrateCommand extends BaseCommand<typeof DocsMigrateCo | |
|
|
||
| let unsortedFiles = await findPages.call(this, pathInput); | ||
|
|
||
| let transformedByHooks = false; | ||
| let transformedByHooks: boolean = false; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| const validationHookResults = await this.config.runHook<'pre_markdown_validation', PluginHooks>( | ||
| 'pre_markdown_validation', | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -73,7 +73,7 @@ function constructCommandString(commandId: string, args: CommandArg, flags: Comm | |
| .map(flag => { | ||
| const val = opts[flag]; | ||
| // obfuscate the key in a GitHub secret | ||
| if (flag === 'key') return `--key=$\{{ secrets.${GITHUB_SECRET_NAME} }}`; | ||
| if (flag === 'key') return `--key=\${{ secrets.${GITHUB_SECRET_NAME} }}`; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. biome was flagging this as an unnecessary escape character but i don't think that's true, but this harmless little tweak silenced the error 🤷🏽
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm actually surprised the former works, but I verified that both do
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah i think the updated escape sequencing is technically a bit better |
||
| // remove the GitHub flag | ||
| if (flag === 'github') return false; | ||
| // if a boolean value, return the flag | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,38 +12,35 @@ export default function getCurrentConfig(this: Hook.Context): { | |
| project?: string; | ||
| } { | ||
| const apiKey = (() => { | ||
| switch (true) { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these |
||
| case !!process.env.RDME_API_KEY: | ||
| this.debug('using RDME_API_KEY env var for api key'); | ||
| return process.env.RDME_API_KEY; | ||
| case !!process.env.README_API_KEY: | ||
| this.debug('using README_API_KEY env var for api key'); | ||
| return process.env.README_API_KEY; | ||
| default: | ||
| this.debug('falling back to configstore value for api key'); | ||
| return configstore.get('apiKey'); | ||
| if (process.env.RDME_API_KEY) { | ||
| this.debug('using RDME_API_KEY env var for api key'); | ||
| return process.env.RDME_API_KEY; | ||
| } else if (process.env.README_API_KEY) { | ||
| this.debug('using README_API_KEY env var for api key'); | ||
| return process.env.README_API_KEY; | ||
| } else { | ||
| this.debug('falling back to configstore value for api key'); | ||
| return configstore.get('apiKey'); | ||
| } | ||
| })(); | ||
|
|
||
| const email = (() => { | ||
| switch (true) { | ||
| case !!process.env.RDME_EMAIL: | ||
| this.debug('using RDME_EMAIL env var for email'); | ||
| return process.env.RDME_EMAIL; | ||
| default: | ||
| this.debug('falling back to configstore value for email'); | ||
| return configstore.get('email'); | ||
| if (process.env.RDME_EMAIL) { | ||
| this.debug('using RDME_EMAIL env var for email'); | ||
| return process.env.RDME_EMAIL; | ||
| } else { | ||
| this.debug('falling back to configstore value for email'); | ||
| return configstore.get('email'); | ||
| } | ||
| })(); | ||
|
|
||
| const project = (() => { | ||
| switch (true) { | ||
| case !!process.env.RDME_PROJECT: | ||
| this.debug('using RDME_PROJECT env var for project'); | ||
| return process.env.RDME_PROJECT; | ||
| default: | ||
| this.debug('falling back to configstore value for project'); | ||
| return configstore.get('project'); | ||
| if (process.env.RDME_PROJECT) { | ||
| this.debug('using RDME_PROJECT env var for project'); | ||
| return process.env.RDME_PROJECT; | ||
| } else { | ||
| this.debug('falling back to configstore value for project'); | ||
| return configstore.get('project'); | ||
| } | ||
| })(); | ||
|
|
||
|
|
||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a handful of false positives with this
lint/nursery/noUnnecessaryConditionsrule that started cropping up. i decided to individually ignore them since i imagine biome will fix these quirks over time and we can remove these ignore statements once that happens.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up turning this rule off in our shared config because it's so buggy but I haven't shipped a release of that yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, i'll leave these as is for now until we do that