Skip to content

Conversation

@nienn
Copy link
Contributor

@nienn nienn commented Jan 20, 2022

agjohnson and others added 2 commits January 20, 2022 16:46
This was removing images as well, which we don't want.
@nienn nienn requested a review from a team as a code owner January 20, 2022 17:24
@nienn nienn changed the base branch from main to nienn/product-page-template January 20, 2022 17:25
@nienn nienn mentioned this pull request Jan 20, 2022

<div class="description">

<div class="ui list relaxed divided">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mimic above and instead use "All open source plan features, plus:" here? The only difference is ads are removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done in commit 41dcffd.

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last review for this first. Updates look good so far!

<div class="ui vertical segment basic very padded center aligned">
<h3 class="ui header massive">Enterprise plans</h3>
<p>
Offer flexible options for your organizations, whether hosting public or private documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking again, this sentence can be dropped. The lead we want for enterprise plans is probably the line below this, "For enterprise documentation needs..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following discussion above, this section was significantly reduced in commit 3a673c9 and the text substituted by a link to the docs page choosing-between-our-two-sites and one short paragraph pulled from that page.

We are happy to work with you on any additional requests you might have. Reach out with your specific needs.
</p>
<p>
Still Have Questions? <span class="ui segment basic tiny"><a href="" class="ui button black mini">Contact us</a></span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Still Have Questions? <span class="ui segment basic tiny"><a href="" class="ui button black mini">Contact us</a></span>
Still have questions? <span class="ui segment basic tiny"><a href="mailto:[email protected]" class="ui button black mini">Contact us</a></span>

Copy link
Contributor Author

@nienn nienn Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this wasn't committed with the batch but the next commit - 3a673c9 - reduces this section so it no longer applies.

@agjohnson agjohnson merged commit 6ab673d into nienn/product-page-template Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants