Passing scheduler to EventLoopDispatcher, schedulerWrapBlockingFunction and through RealmConfig#7903
Draft
kraenhansen wants to merge 5 commits intomasterfrom
Draft
Passing scheduler to EventLoopDispatcher, schedulerWrapBlockingFunction and through RealmConfig#7903kraenhansen wants to merge 5 commits intomasterfrom
EventLoopDispatcher, schedulerWrapBlockingFunction and through RealmConfig#7903kraenhansen wants to merge 5 commits intomasterfrom
Conversation
12 tasks
added 4 commits
July 19, 2024 14:59
1f54a63 to
0f0e1ed
Compare
Author
|
This could probably merge, but it's unlikely that the JS PR depending on it will merge anytime soon. |
Pull Request Test Coverage Report for Build kraen.hansen_76Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This allows the JS SDK to pass a
util::Schedulerto theEventLoopDispatcherandschedulerWrapBlockingFunctionutilities as well as through theRealmConfigwhen opening a Realm.☑️ ToDos
bindgen/spec.yml, if public C++ API changed