Skip to content

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Oct 9, 2025

@staabm per latest type-perfect PR:

that cause notice:

➜  rector-phpunit git:(main) composer phpstan                                                      
Note: Using configuration file /Users/samsonasik/www/rector-phpunit/phpstan.neon.
 304/304 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  rules/PHPUnit100/Rector/StmtsAwareInterface/ExpectsMethodCallDecorator.php:34
 -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  - '#Parameters should have "PhpParser\\Node\\Stmt\\Expression" types as the only types passed to this method#'
  🪪 typePerfect.narrowPublicClassMethodParamType
 -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


                                                                                                                        
 [ERROR] Found 1 errors                                                                                                 
                                                                                                                        

Script vendor/bin/phpstan analyse --ansi handling the phpstan event returned with error code 1

This PR ignore the notice for now.

@samsonasik samsonasik changed the title Ignote PHPStan notice typePerfect.narrowPublicClassMethodParamType on ExpectsMethodCallDecorator Ignore PHPStan notice typePerfect.narrowPublicClassMethodParamType on ExpectsMethodCallDecorator Oct 9, 2025
@samsonasik samsonasik enabled auto-merge (squash) October 9, 2025 16:23
@samsonasik samsonasik merged commit 9329da8 into main Oct 9, 2025
6 checks passed
@samsonasik samsonasik deleted the fix-phsptan-2 branch October 9, 2025 16:24
@TomasVotruba
Copy link
Member

Why not fix it? Is it some public api?

@samsonasik
Copy link
Member Author

I am not sure if it is a bug of type-perfect or invalid syntax itself, this seems introduced by PR:

@staabm
Copy link
Contributor

staabm commented Oct 9, 2025

here we go: #552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants