-
Notifications
You must be signed in to change notification settings - Fork 8
Fix "types as the only types passed to this method" false positive on generic parameter types #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@TomasVotruba do you think this one is ready to merge and release? :) |
Member
|
Thanks for the ping. It's been a long time since understood this logic 😅 I'll trust your fix, let's give it a go 👍 Thanks |
Contributor
Author
|
thank you. would be great to get this into a release |
Member
Member
|
@staabm this seems cause issue on rector-phpunit repo I am going to ignore for now. |
Member
Contributor
Author
|
Will have a look tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix reproducer for #59
for some reason I don't understand the test-suite only errors for this case on first-class callables, while in real world projects we see the same error on non-first-class-callables.
I verfied that this fix also fixes my real world project bug which is is reported on a non-first-class callable (as the test-case showcased before this PR)