Skip to content

Conversation

Meghagaur
Copy link

Description

  • Added a patch to build vscode for s390x in get_code_server_rpm.sh to resolve wasm magic number error in web-tree-sitter module
  • Added Target flags for building openblas from source in devel_env_setup.sh
  • Added required packages for pillow and scipy in devel_env_setup.sh
  • Skipped py-spy and skl2onnx in pyproject.toml
  • Updated the vsix files with updated extentions from Open-vsx.com

How Has This Been Tested?

  • Created a test PR in downstream Test: Test PR to test codeserver for Z to test the image build on konflux.
  • Created a Code Server workbench on RHOAI and successfully ran a Python script in it.

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and dibryant October 11, 2025 10:42
Copy link

openshift-ci bot commented Oct 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign daniellutz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Oct 11, 2025

Hi @Meghagaur. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Nash-123
Copy link

Hi @jiridanek , can you please help to review this PR. Thanks!

npm install
npm run build
VERSION=${CODESERVER_VERSION/v/} npm run build:vscode
export KEEP_MODULES=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Author

@Meghagaur Meghagaur Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git clone --depth 1 --branch "${CODESERVER_VERSION}" --recurse-submodules --shallow-submodules https://github.com/coder/code-server.git
cd code-server

#patch taken from vscodium s390x IBM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Url? What problem does it solve?

Copy link
Author

@Meghagaur Meghagaur Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is the url
https://github.com/VSCodium/vscodium/blob/master/patches/linux/reh/s390x/arch-4-s390x-package.json.patch

There was an error for wasm magic number in web-tree-sitter ( a node dependency of vscode ) while building the codeserver rpm.

`# error

[email protected] build:vscode
./ci/build/build-vscode.sh
Updated 1 path from the index
[email protected] gulp
node --max-old-space-size=8192 ./node_modules/gulp/bin/gulp.js vscode-reh-web-linux-s390x-min
[06:58:36] Using gulpfile ~/Test-codeserver/code-server/lib/vscode/gulpfile.js
[06:58:36] Starting 'vscode-reh-web-linux-s390x-min'...
[06:58:36] Starting clean-out-build ...
Unhandled Rejection at: Promise Promise {
Error: need to see wasm magic number
at s (/root/Test-codeserver/code-server/lib/vscode/node_modules/@vscode/l10n-dev/node_modules/web-tree-sitter/tree-sitter.js:1:9928) `


# Install OpenBlas
# IMPORTANT: Ensure Openblas is installed in the final image
curl -L https://github.com/OpenMathLib/OpenBLAS/releases/download/v${OPENBLAS_VERSION}/OpenBLAS-${OPENBLAS_VERSION}.tar.gz | tar xz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to stop downloading stuff in scripts, we need to use cachi2 for this going forward

@atheo89
Copy link
Member

atheo89 commented Oct 13, 2025

Hi @Meghagaur thank you for opening this PR, Could you please apply these changes on the upstream repo first https://github.com/opendatahub-io/notebooks?

@Meghagaur Meghagaur force-pushed the s390x-codeserver-me branch from aaf09fd to 001c4f6 Compare October 13, 2025 19:22
Copy link

openshift-ci bot commented Oct 14, 2025

@Meghagaur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images e9c106b link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants