-
Notifications
You must be signed in to change notification settings - Fork 22
Added changes to enable codeserver on s390x architecture #1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added changes to enable codeserver on s390x architecture #1627
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Meghagaur. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @jiridanek , can you please help to review this PR. Thanks! |
npm install | ||
npm run build | ||
VERSION=${CODESERVER_VERSION/v/} npm run build:vscode | ||
export KEEP_MODULES=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This copies all the node modules from vscode to codeserver.
https://gitlab.b-data.ch/coder/code-server-builder/-/blob/main/scripts/start.sh?ref_type=heads
git clone --depth 1 --branch "${CODESERVER_VERSION}" --recurse-submodules --shallow-submodules https://github.com/coder/code-server.git | ||
cd code-server | ||
|
||
#patch taken from vscodium s390x IBM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Url? What problem does it solve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here is the url
https://github.com/VSCodium/vscodium/blob/master/patches/linux/reh/s390x/arch-4-s390x-package.json.patch
There was an error for wasm magic number in web-tree-sitter ( a node dependency of vscode ) while building the codeserver rpm.
`# error
[email protected] build:vscode
./ci/build/build-vscode.sh
Updated 1 path from the index
[email protected] gulp
node --max-old-space-size=8192 ./node_modules/gulp/bin/gulp.js vscode-reh-web-linux-s390x-min
[06:58:36] Using gulpfile ~/Test-codeserver/code-server/lib/vscode/gulpfile.js
[06:58:36] Starting 'vscode-reh-web-linux-s390x-min'...
[06:58:36] Starting clean-out-build ...
Unhandled Rejection at: Promise Promise {
Error: need to see wasm magic number
at s (/root/Test-codeserver/code-server/lib/vscode/node_modules/@vscode/l10n-dev/node_modules/web-tree-sitter/tree-sitter.js:1:9928) `
|
||
# Install OpenBlas | ||
# IMPORTANT: Ensure Openblas is installed in the final image | ||
curl -L https://github.com/OpenMathLib/OpenBLAS/releases/download/v${OPENBLAS_VERSION}/OpenBLAS-${OPENBLAS_VERSION}.tar.gz | tar xz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to stop downloading stuff in scripts, we need to use cachi2 for this going forward
Hi @Meghagaur thank you for opening this PR, Could you please apply these changes on the upstream repo first https://github.com/opendatahub-io/notebooks? |
aaf09fd
to
001c4f6
Compare
@Meghagaur: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
How Has This Been Tested?
Self checklist (all need to be checked):
make test
(gmake
on macOS) before asking for reviewDockerfile.konflux
files should be done inodh/notebooks
and automatically synced torhds/notebooks
. For Konflux-specific changes, modifyDockerfile.konflux
files directly inrhds/notebooks
as these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: