-
Notifications
You must be signed in to change notification settings - Fork 22
Added changes to enable codeserver on s390x architecture #1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
fc63783
1ff7c85
394bdf1
c773691
ed4eae9
8300ffc
ddfb9c5
a22248d
3929dcb
27e3ad7
77a168b
a91156b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ All Tekton file updates **must be made in the `konflux-central` repository**. | |
|
||
## ✅ How to Make Changes | ||
|
||
To modify the pipelines for `notebooks` in the `main` branch: | ||
To modify the pipelines for `notebooks` in the `rhoai-3.0` release: | ||
|
||
- Clone the [`konflux-central`](https://github.com/red-hat-data-services/konflux-central) repository. | ||
|
||
|
@@ -15,10 +15,10 @@ git clone [email protected]:red-hat-data-services/konflux-central.git | |
cd konflux-central | ||
``` | ||
|
||
- Check out the branch | ||
- Check out the release branch | ||
|
||
```bash | ||
git checkout main | ||
git checkout rhoai-3.0 | ||
``` | ||
|
||
- Navigate to the Tekton files for your component(s). | ||
|
@@ -32,8 +32,8 @@ cd pipelineruns/notebooks/.tekton | |
- Commit and push your changes. | ||
|
||
```bash | ||
git commit -am "Update pipelinerun for notebooks (main)" | ||
git push origin main | ||
git commit -am "Update pipelinerun for notebooks (rhoai-3.0)" | ||
git push origin rhoai-3.0 | ||
``` | ||
|
||
- Once pushed, automation will automatically sync your updates to the corresponding component repository. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ UNAME_TO_GOARCH["s390x"]="s390x" | |
|
||
ARCH="${UNAME_TO_GOARCH[$(uname -m)]}" | ||
|
||
if [[ "$ARCH" == "amd64" || "$ARCH" == "arm64" ||"$ARCH" == "ppc64le" ]]; then | ||
if [[ "$ARCH" == "amd64" || "$ARCH" == "arm64" ||"$ARCH" == "ppc64le" || "$ARCH" == "s390x" ]]; then | ||
|
||
export MAX_JOBS=${MAX_JOBS:-$(nproc)} | ||
export NODE_VERSION=${NODE_VERSION:-22.18.0} | ||
|
@@ -62,12 +62,57 @@ if [[ "$ARCH" == "amd64" || "$ARCH" == "arm64" ||"$ARCH" == "ppc64le" ]]; then | |
# build codeserver | ||
git clone --depth 1 --branch "${CODESERVER_VERSION}" --recurse-submodules --shallow-submodules https://github.com/coder/code-server.git | ||
cd code-server | ||
|
||
#patch taken from vscodium s390x IBM | ||
if [[ "$ARCH" == "s390x" ]]; then | ||
cat > s390x.patch <<EOL | ||
diff --git a/lib/vscode/package-lock.json b/lib/vscode/package-lock.json | ||
index 0d0272a92b2..73e8feb92dd 100644 | ||
--- a/lib/vscode/package-lock.json | ||
+++ b/lib/vscode/package-lock.json | ||
@@ -18236,10 +18236,11 @@ | ||
} | ||
}, | ||
"node_modules/web-tree-sitter": { | ||
- "version": "0.20.8", | ||
- "resolved": "https://registry.npmjs.org/web-tree-sitter/-/web-tree-sitter-0.20.8.tgz", | ||
- "integrity": "sha512-weOVgZ3aAARgdnb220GqYuh7+rZU0Ka9k9yfKtGAzEYMa6GgiCzW9JjQRJyCJakvibQW+dfjJdihjInKuuCAUQ==", | ||
- "dev": true | ||
+ "version": "0.23.0", | ||
+ "resolved": "https://registry.npmjs.org/web-tree-sitter/-/web-tree-sitter-0.23.0.tgz", | ||
+ "integrity": "sha512-p1T+ju2H30fpVX2q5yr+Wv/NfdMMWMjQp9Q+4eEPrHAJpPFh9DPfI2Yr9L1f5SA5KPE+g1cNUqPbpihxUDzmVw==", | ||
+ "dev": true, | ||
+ "license": "MIT" | ||
}, | ||
"node_modules/webidl-conversions": { | ||
"version": "3.0.1", | ||
diff --git a/lib/vscode/package.json b/lib/vscode/package.json | ||
index a4c7a2a3a35..d7f816248af 100644 | ||
--- a/lib/vscode/package.json | ||
+++ b/lib/vscode/package.json | ||
@@ -227,6 +227,9 @@ | ||
"node-gyp-build": "4.8.1", | ||
"[email protected]": { | ||
"node-addon-api": "7.1.0" | ||
+ }, | ||
+ "@vscode/[email protected]": { | ||
+ "web-tree-sitter": "0.23.0" | ||
} | ||
}, | ||
"repository": { | ||
EOL | ||
|
||
git apply s390x.patch | ||
fi | ||
|
||
source ${NVM_DIR}/nvm.sh | ||
while IFS= read -r src_patch; do echo "patches/$src_patch"; patch -p1 < "patches/$src_patch"; done < patches/series | ||
nvm use ${NODE_VERSION} | ||
npm cache clean --force | ||
npm install | ||
npm run build | ||
VERSION=${CODESERVER_VERSION/v/} npm run build:vscode | ||
export KEEP_MODULES=1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does this do? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This copies all the node modules from vscode to codeserver. |
||
npm run release | ||
npm run release:standalone | ||
|
||
|
Meghagaur marked this conversation as resolved.
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Url? What problem does it solve?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here is the url
https://github.com/VSCodium/vscodium/blob/master/patches/linux/reh/s390x/arch-4-s390x-package.json.patch
There was an error for wasm magic number in web-tree-sitter ( a node dependency of vscode ) while building the codeserver rpm.
`# error