controllers: approve InstallPlans only in RequiresApproval phase #724
Conversation
Approve InstallPlans only after OLM reaches RequiresApproval OLM creates an initial InstallPlan that was approved immediately by the ODF operator while OLM was still processing it. OLM then detected the change as a modification conflict, treated the InstallPlan as invalid, and created a second duplicate InstallPlan. Subscriptions were updated to point to the new InstallPlan, which remained unapproved and caused upgrades to get stuck in UpgradePending. To prevent this, InstallPlans are now approved only after they reach the RequiresApproval phase, indicating that OLM has finished processing and is explicitly waiting for an external approver. This avoids the conflict, prevents duplicate InstallPlans, and ensures upgrades complete successfully. Signed-off-by: Nitin Goyal <[email protected]>
openshift-ci
bot
added
the
approved
|
/cherry-pick release-4.21 |
|
@iamniting: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, Nikhil-Ladha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 7ec6a69
into
red-hat-storage:main
|
@iamniting: new pull request created: #725 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@iamniting: new pull request created: #726 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Approve InstallPlans only after OLM reaches RequiresApproval
OLM creates an initial InstallPlan that was approved immediately by the ODF operator while OLM was still processing it. OLM then detected the change as a modification conflict, treated the InstallPlan as invalid, and created a second duplicate InstallPlan. Subscriptions were updated to point to the new InstallPlan, which remained unapproved and caused upgrades to get stuck in UpgradePending.
To prevent this, InstallPlans are now approved only after they reach the RequiresApproval phase, indicating that OLM has finished processing and is explicitly waiting for an external approver. This avoids the conflict, prevents duplicate InstallPlans, and ensures upgrades complete successfully.
Signed-off-by: Nitin Goyal [email protected]
More info regarding this change can be found in JIRA where this change was suggested by
Kursad Yildirim: https://issues.redhat.com/browse/DFBUGS-5327