Skip to content

Conversation

@rnc
Copy link
Collaborator

@rnc rnc commented Oct 24, 2024

Changes to the task yamls are to allow the settings.xml to be stored in the OCI image as well thereby making it available to the deploy step. This will be useful when deploying to Indy.

tls workspace references been removed from the tasks as they aren't required (within JBS we're running with disableTLS currently so they are unused and wouldn't work in the new layout anyway).

For JBS, this normalizes to a single pipeline (note that not all of the code from the secondary pipeline added in #1597 and #1625 has been removed/reverted). I also isolated the storage for the verify step so that any testing does not affect the deploy step.

@rnc rnc requested a review from matejonnet October 24, 2024 08:51
@openshift-ci openshift-ci bot requested a review from vibe13 October 24, 2024 08:51
@rnc
Copy link
Collaborator Author

rnc commented Oct 24, 2024

/retest

@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 98.90110% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.95%. Comparing base (f919901) to head (63ced54).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/dependencybuild/dependencybuild.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2224      +/-   ##
============================================
- Coverage     44.02%   43.95%   -0.07%     
  Complexity      811      811              
============================================
  Files           276      276              
  Lines         13464    13328     -136     
  Branches       1360     1360              
============================================
- Hits           5927     5858      -69     
+ Misses         6914     6861      -53     
+ Partials        623      609      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

const (
KonfluxGitDefinition = "https://raw.githubusercontent.com/konflux-ci/build-definitions/refs/heads/main/task/git-clone/0.1/git-clone.yaml"
KonfluxPreBuildDefinitions = "https://raw.githubusercontent.com/redhat-appstudio/jvm-build-service/main/deploy/tasks/pre-build.yaml"
KonfluxPreBuildDefinitions = "https://raw.githubusercontent.com/rnc/jvm-build-service/PIPELINE/deploy/tasks/pre-build.yaml"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using rnc repo ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task changes always have to be done in two stages - first with the reference to my branch then onces it merged into main it a subsequent PR to change the reference back. Its due to using the git resolver.

@rnc rnc merged commit b674871 into redhat-appstudio:main Oct 28, 2024
26 checks passed
@rnc rnc deleted the PIPELINE branch October 28, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants