-
Notifications
You must be signed in to change notification settings - Fork 31
Use single pipeline #2224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use single pipeline #2224
Conversation
|
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2224 +/- ##
============================================
- Coverage 44.02% 43.95% -0.07%
Complexity 811 811
============================================
Files 276 276
Lines 13464 13328 -136
Branches 1360 1360
============================================
- Hits 5927 5858 -69
+ Misses 6914 6861 -53
+ Partials 623 609 -14 ☔ View full report in Codecov by Sentry. |
| const ( | ||
| KonfluxGitDefinition = "https://raw.githubusercontent.com/konflux-ci/build-definitions/refs/heads/main/task/git-clone/0.1/git-clone.yaml" | ||
| KonfluxPreBuildDefinitions = "https://raw.githubusercontent.com/redhat-appstudio/jvm-build-service/main/deploy/tasks/pre-build.yaml" | ||
| KonfluxPreBuildDefinitions = "https://raw.githubusercontent.com/rnc/jvm-build-service/PIPELINE/deploy/tasks/pre-build.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using rnc repo ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Task changes always have to be done in two stages - first with the reference to my branch then onces it merged into main it a subsequent PR to change the reference back. Its due to using the git resolver.
Changes to the task yamls are to allow the settings.xml to be stored in the OCI image as well thereby making it available to the deploy step. This will be useful when deploying to Indy.
tlsworkspace references been removed from the tasks as they aren't required (within JBS we're running withdisableTLScurrently so they are unused and wouldn't work in the new layout anyway).For JBS, this normalizes to a single pipeline (note that not all of the code from the secondary pipeline added in #1597 and #1625 has been removed/reverted). I also isolated the storage for the verify step so that any testing does not affect the deploy step.